This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Disable raw send tests on unsupported platform. #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
reviewed
Sep 16, 2022
| @@ -7,7 +7,7 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
| // REQUIRES: gpu-intel-gen9 | |||
| // UNSUPPORTED: gpu-intel-dg1,cuda,hip | |||
| // UNSUPPORTED: gpu-intel-dg1,gpu-intel-dg2,cuda,hip | |||
There was a problem hiding this comment.
This whole line looks odd and... redundant. I'd think it can be just removed.
Doesn't the line 9 require gen9 and prohibit from running on dg1,dg2,cuda,hip ?
There was a problem hiding this comment.
I'd assume so but there is a regression report indicating it's failing on dg2.
If you are sure line 9 is sufficient to exclude the test on other platform, then we shouldn't need any fix.
v-klochkov
approved these changes
Sep 17, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.