Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[ESIMD] Disable raw send tests on unsupported platform. #1271

Merged
merged 1 commit into from
Sep 17, 2022
Merged

[ESIMD] Disable raw send tests on unsupported platform. #1271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SYCL/ESIMD/histogram_raw_send.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
//
//===----------------------------------------------------------------------===//
// REQUIRES: gpu-intel-gen9
// UNSUPPORTED: gpu-intel-dg1,cuda,hip
// UNSUPPORTED: gpu-intel-dg1,gpu-intel-dg2,cuda,hip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole line looks odd and... redundant. I'd think it can be just removed.
Doesn't the line 9 require gen9 and prohibit from running on dg1,dg2,cuda,hip ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd assume so but there is a regression report indicating it's failing on dg2.
If you are sure line 9 is sufficient to exclude the test on other platform, then we shouldn't need any fix.

// UNSUPPORTED: ze_debug-1,ze_debug4
// RUN: %clangxx -fsycl %s -o %t.out
// RUN: %GPU_RUN_PLACEHOLDER %t.out
Expand Down
2 changes: 1 addition & 1 deletion SYCL/ESIMD/vadd_raw_send.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
//
//===----------------------------------------------------------------------===//
// REQUIRES: gpu-intel-gen9
// UNSUPPORTED: gpu-intel-dg1,cuda,hip
// UNSUPPORTED: gpu-intel-dg1,gpu-intel-dg2,cuda,hip
// TODO: esimd_emulator fails due to unimplemented 'raw_send' intrinsic
// XFAIL: esimd_emulator
// RUN: %clangxx -fsycl %s -o %t.out
Expand Down