This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD]Add tests for support for different types for lsc functions #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Complementary compiler PR intel/llvm#6952 |
v-klochkov
reviewed
Oct 4, 2022
SYCL/ESIMD/lsc/Inputs/common.hpp
Outdated
| @@ -11,8 +11,9 @@ | |||
| template <int case_num> class KernelID; | |||
|
|
|||
| template <typename T> T get_rand() { | |||
| T v = rand(); | |||
| if constexpr (sizeof(T) > 4) | |||
| using Tuint = sycl::_V1::ext::intel::esimd::detail::uint_type_t<sizeof(T)>; | |||
There was a problem hiding this comment.
I believe 'detail' namespace is for SYCL internal needs only, it should not be used in tests.
uint_type_t can be defined in this 'common.hpp' file.
v-klochkov
reviewed
Oct 4, 2022
SYCL/ESIMD/lsc/Inputs/common.hpp
Outdated
| v = (v << 32) | rand(); | ||
| return v; | ||
| return (*(T *)&v); |
There was a problem hiding this comment.
Suggested change
| return (*(T *)&v); | |
| return bit_cast<T>(v); |
v-klochkov
approved these changes
Oct 5, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…el#1315) (intel#1305) The removed sub-tests were incorrect as they stored garbage (random return from lsc_block_load(with preducate=0) to result and then checking it with something meaningful expected values.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…ons (intel#1305) * Add tests for support for different types for lsc functions
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ons (intel/llvm-test-suite#1305) * Add tests for support for different types for lsc functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.