This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Fix lsc predicate test that failed on PVC hardware #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
reviewed
Oct 13, 2022
SYCL/ESIMD/lsc/lsc_predicate.cpp
Outdated
Comment on lines
131
to
134
| auto data_2 = | ||
| lsc_block_load<int, SIMDSize>(vec_2 + offset, pred_enable); | ||
| lsc_block_load<int, SIMDSize>(vec_2 + offset, pred_disable); | ||
| lsc_block_store<int, SIMDSize>(vec_2 + offset, data_2 * 2, | ||
| pred_disable); |
There was a problem hiding this comment.
This test case is just redundant, right?
If lsc_block_load with pred_diable works incorrectly, the test only verifies lsc_block_store on the line 133, and such check already exists on the line 129.
v-klochkov
approved these changes
Oct 13, 2022
|
The failed tests are unrelated to those 2 being updated in this PR: |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…el#1315) (intel#1305) The removed sub-tests were incorrect as they stored garbage (random return from lsc_block_load(with preducate=0) to result and then checking it with something meaningful expected values.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…el#1315) The removed sub-tests were incorrect as they stored garbage (random return from lsc_block_load(with preducate=0) to result and then checking it with something meaningful expected values.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…el/llvm-test-suite#1315) The removed sub-tests were incorrect as they stored garbage (random return from lsc_block_load(with preducate=0) to result and then checking it with something meaningful expected values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.