Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][ESIMD] Add test to validate tanh function fix #1361

Merged
merged 2 commits into from
Nov 8, 2022
Merged

[SYCL][ESIMD] Add test to validate tanh function fix #1361

merged 2 commits into from
Nov 8, 2022

Conversation

fineg74
Copy link

@fineg74 fineg74 commented Nov 3, 2022

No description provided.

@fineg74 fineg74 requested a review from a team as a code owner November 3, 2022 01:42
@fineg74
Copy link
Author

fineg74 commented Nov 3, 2022

Complementary compiler PR intel/llvm#7265

@fineg74 fineg74 mentioned this pull request Nov 3, 2022
Merged
v-klochkov
v-klochkov reviewed Nov 3, 2022
View reviewed changes
Copy link

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 3 comments. Thank you.

SYCL/ESIMD/regression/tanh_fix_test.cpp Outdated
// RUN: %clangxx -fsycl %s -o %t.out
// RUN: %GPU_RUN_PLACEHOLDER %t.out

//==- tanh_compatibility_test.cpp - Test for tanh -==//
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be tanh_fix_test.cpp in this line. Or it is better to rename the test to tanh_compatibility_test.cpp

@v-klochkov
Copy link

/verify with intel/llvm#7265

@v-klochkov
Copy link

@fineg74 - The new LIT test failed on Windows with the fixed compiler. Please see Jenkins/llvm-test-suite:

[2022-11-04T17:49:58.784Z] Scalar test failed for -43.9009.
[2022-11-04T17:49:58.784Z] Scalar test failed for -43.8009.
[2022-11-04T17:49:58.784Z] Scalar test failed for -43.7009.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.699.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.799.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.899.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.999.

@fineg74
Copy link
Author

fineg74 commented Nov 6, 2022

/verify with intel/llvm#7265

1 similar comment
@fineg74
Copy link
Author

fineg74 commented Nov 7, 2022

/verify with intel/llvm#7265

@fineg74
Copy link
Author

fineg74 commented Nov 7, 2022

@fineg74 - The new LIT test failed on Windows with the fixed compiler. Please see Jenkins/llvm-test-suite:

[2022-11-04T17:49:58.784Z] Scalar test failed for -43.9009.
[2022-11-04T17:49:58.784Z] Scalar test failed for -43.8009.
[2022-11-04T17:49:58.784Z] Scalar test failed for -43.7009.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.699.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.799.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.899.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.999.

Fixed.
The only failure I see on Windows is
kernel-bundle-merge-options-env.cpp

@fineg74
Copy link
Author

fineg74 commented Nov 7, 2022

@fineg74 - The new LIT test failed on Windows with the fixed compiler. Please see Jenkins/llvm-test-suite:

[2022-11-04T17:49:58.784Z] Scalar test failed for -43.9009.
[2022-11-04T17:49:58.784Z] Scalar test failed for -43.8009.
[2022-11-04T17:49:58.784Z] Scalar test failed for -43.7009.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.699.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.799.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.899.
[2022-11-04T17:49:58.784Z] Scalar test failed for 43.999.

Fixed.
The only failing test on Windows at the moment is KernelAndProgram/kernel-bundle-merge-options-env.cpp

@v-klochkov v-klochkov merged commit b279d46 into intel:intel Nov 8, 2022
@steffenlarsen
Copy link

@fineg74 - The added test is passing unexpectedly on the ESIMD emulator. See https://github.com/intel/llvm/actions/runs/3427185876/jobs/5710264219.

This was referenced Nov 9, 2022
Merged
Merged
@pvchupin pvchupin mentioned this pull request Nov 10, 2022
Merged
@fineg74 fineg74 deleted the tanhFixTest branch January 5, 2023 17:46
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@fineg74 @bb-sycl
[ESIMD] Add test to validate tanh function fix (intel#1361)
b17f4de
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@fineg74
[ESIMD] Add test to validate tanh function fix (intel/llvm-test-suite…
bac9009 
…#1361)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fineg74 @v-klochkov @steffenlarsen