[SYCL] Fix two reduction bugs #7347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one in NDRangeReduction<reduction::strategy::basic> was introduced during most recent reduction refactoring and most likely could only be triggered through internal API calls. Code path for public APIs is such that this strategy isn't auto-selected under conditions leading to the bug. I think another one (strategy::group_reduce_and_last_wg_detection) was introduced earlier (a couple of months maybe) and probably was user-visible.
|
This will be tested by intel/llvm-test-suite#1373, but I need this, #7346 and one more future PR for reductions (ready locally, but dependent on #7346) to enable that test. |
steffenlarsen
approved these changes
Nov 10, 2022
|
Failures are all known and are being addressed in other PRs already. @intel/llvm-gatekeepers , this PR is ready I believe. |
|
SYCL :: Regression/device_num.cpp - Reported to owner in intel/llvm-test-suite#1354 (comment) with fix up in #7336. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one in NDRangeReductionreduction::strategy::basic was introduced during most recent reduction refactoring and most likely could only be triggered through internal API calls. Code path for public APIs is such that this strategy isn't auto-selected under conditions leading to the bug.
I think another one (strategy::group_reduce_and_last_wg_detection) was introduced earlier (a couple of months maybe) and probably was user-visible.
Both bugs were caused by some extra erroneous conditions resulting in taking the wrong branch target.