This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Remove use of SYCL_DEVICE_FILTER from set-arg-local-accessor #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set-arg-local-accessor test uses SYCL_DEVICE_FILTER explicitly which causes failures with recent change to use ONEAPI_DEVICE_SELECTOR because they are mutually exclusive. Since ONEAPI_DEVICE_SELECTOR is added through the *_RUN_PLACEHOLDER macros the SYCL_DEVICE_FILTER is not needed. The filtering for the OpenCL backend is ensured by the `opencl` feature requirement at the top of the test. Signed-off-by: Larsen, Steffen <[email protected]>
This was referenced Nov 10, 2022
AlexeySachkov
approved these changes
Nov 10, 2022
This was referenced Nov 10, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Co-authored-by: aelovikov-intel <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…ntel#1375) The set-arg-local-accessor test uses SYCL_DEVICE_FILTER explicitly which causes failures with recent change to use ONEAPI_DEVICE_SELECTOR because they are mutually exclusive. Since ONEAPI_DEVICE_SELECTOR is added through the *_RUN_PLACEHOLDER macros the SYCL_DEVICE_FILTER is not needed. The filtering for the OpenCL backend is ensured by the `opencl` feature requirement at the top of the test. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#1375) The set-arg-local-accessor test uses SYCL_DEVICE_FILTER explicitly which causes failures with recent change to use ONEAPI_DEVICE_SELECTOR because they are mutually exclusive. Since ONEAPI_DEVICE_SELECTOR is added through the *_RUN_PLACEHOLDER macros the SYCL_DEVICE_FILTER is not needed. The filtering for the OpenCL backend is ensured by the `opencl` feature requirement at the top of the test. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set-arg-local-accessor test uses SYCL_DEVICE_FILTER explicitly which causes failures with recent change to use ONEAPI_DEVICE_SELECTOR because they are mutually exclusive. Since ONEAPI_DEVICE_SELECTOR is added through the *_RUN_PLACEHOLDER macros the SYCL_DEVICE_FILTER is not needed. The filtering for the OpenCL backend is ensured by the
openclfeature requirement at the top of the test.