[SYCL] Add unittest for recent handler::set_arg fixes #7333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexeySachkov, is the fail related? Are you working on that? |
The fail is absolutely related, because the newly added test is failing in CI. I will be looking into it, even though I'm not yet able to reproduce it in my local environment. |
|
Failure in set-arg-local-accessor is caused by a conflict with another recent change. intel/llvm-test-suite#1375 should fix it. |
This reverts commit 723c769.
This is needed to avoid jumps based on unconditional value in program_impl constructor
In unit tests we don't have proper mock implementations for all PI calls, which can lead to some out-parameters not being set which in turn may cause obscure errors.
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 10, 2022
This patch aims to improve situation with unit-tests: a lot of PI routines only hace dummy mock versions of them. Dummy mocks ignore all arguments, leaving out-parameters untoched. Depending on how they used at call site, this could lead to some obscure errors like `bad_alloc` if an uninitialized value was used to set a size of a `vector`. Discovered while working on a unit-test in intel#7333
|
Failed |
steffenlarsen
approved these changes
Nov 10, 2022
|
Fix for post-commit |
AlexeySachkov
added a commit
that referenced
this pull request
Nov 15, 2022
This patch aims to improve situation with unit-tests: a lot of PI routines only have dummy mock versions of them. Dummy mocks ignore all arguments, leaving out-parameters untouched. Depending on how they used at call site, this could lead to some obscure errors like `bad_alloc` if an uninitialized value was used to set a size of a `vector`. Discovered while working on a unit-test in #7333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #7313