[SYCL][NFC] Add initializers to local variables #7350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aims to improve situation with unit-tests: a lot of PI routines only hace dummy mock versions of them. Dummy mocks ignore all arguments, leaving out-parameters untoched. Depending on how they used at call site, this could lead to some obscure errors like `bad_alloc` if an uninitialized value was used to set a size of a `vector`. Discovered while working on a unit-test in intel#7333
steffenlarsen
approved these changes
Nov 10, 2022
KornevNikita
approved these changes
Nov 10, 2022
|
Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to improve situation with unit-tests: a lot of PI routines only have dummy mock versions of them. Dummy mocks ignore all arguments, leaving out-parameters untouched. Depending on how they used at call site, this could lead to some obscure errors like
bad_allocif an uninitialized value was used to set a size of avector.Discovered while working on a unit-test in #7333