Skip to content

[SYCL] Fix handler::set_arg for local_accessor #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2022
Merged

[SYCL] Fix handler::set_arg for local_accessor #7313

merged 2 commits into from
Nov 8, 2022

Conversation

AlexeySachkov
Copy link
Contributor

Added missing setArgHelper overload for local_accessor.

@AlexeySachkov
[SYCL] Fix handler::set_arg for local_accessor
1f1a99c 
Added missing `setArgHelper` overload for `local_accessor`.
@AlexeySachkov AlexeySachkov mentioned this pull request Nov 8, 2022
Merged
@AlexeySachkov
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1367

@AlexeySachkov AlexeySachkov marked this pull request as ready for review November 8, 2022 12:23
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner November 8, 2022 12:23
@AlexeySachkov AlexeySachkov requested review from bso-intel and a team November 8, 2022 12:23
steffenlarsen
steffenlarsen approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexeySachkov
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1367

1 similar comment
@AlexeySachkov
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1367

@AlexeySachkov
Copy link
Contributor Author

Failures in llvm-test-suite are not related to the changes, I will merge this and try to investigate and/or temporary disable some tests

@AlexeySachkov AlexeySachkov merged commit ef792c6 into intel:sycl Nov 8, 2022
AlexeySachkov added a commit to intel/llvm-test-suite that referenced this pull request Nov 8, 2022
@AlexeySachkov
[SYCL] Add test for set_arg with local_accessor (#1367)
de95dbf 
Related change: intel/llvm#7313
@pvchupin
Copy link
Contributor

pvchupin commented Nov 9, 2022 •
edited by steffenlarsen
Loading

@AlexeySachkov, please follow up on post commit issue: https://github.com/intel/llvm/actions/runs/3423451915/jobs/5702059148

?setLocalAccessorArgHelper@handler@_V1@sycl@@AEAAXHAEAVLocalAccessorBaseHost@detail@23@@Z

steffenlarsen added a commit to steffenlarsen/llvm that referenced this pull request Nov 9, 2022
@steffenlarsen
[SYCL][NFC] Add missing windows symbol for setLocalAccessorHelper
92d1c33 
intel#7313 added the setLocalAccessorHelper
function which has a symbol in the Windows dump. This commit adds the
missing symbol to the reference dump.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen mentioned this pull request Nov 9, 2022
Merged
@steffenlarsen
Copy link
Contributor

@AlexeySachkov, please follow up on post commit issue: https://github.com/intel/llvm/actions/runs/3423451915/jobs/5702059148

?setLocalAccessorArgHelper@handler@_V1@sycl@@AEAAXHAEAVLocalAccessorBaseHost@detail@23@@Z

Added in #7331

AlexeySachkov added a commit to AlexeySachkov/llvm that referenced this pull request Nov 9, 2022
@AlexeySachkov
[SYCL] Add unittest for recent handler::set_arg fixes
a4f6af9 
Related PR: intel#7313
@AlexeySachkov AlexeySachkov mentioned this pull request Nov 9, 2022
Merged
steffenlarsen added a commit that referenced this pull request Nov 9, 2022
@steffenlarsen
[SYCL][NFC] Add missing windows symbol for setLocalAccessorHelper (#7331
fdfb2e6 
)

#7313 added the setLocalAccessorHelper
function which has a symbol in the Windows dump. This commit adds the
missing symbol to the reference dump.

Signed-off-by: Larsen, Steffen <[email protected]>
AlexeySachkov added a commit that referenced this pull request Nov 10, 2022
@AlexeySachkov
[SYCL] Add unittest for recent handler::set_arg fixes (#7333)
4be64e7 
Related PR: #7313
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@AlexeySachkov
[SYCL] Add test for set_arg with local_accessor (intel/llvm-test-suit…
9f21df2 
…e#1367)

Related change: intel#7313
@AlexeySachkov AlexeySachkov deleted the private/asachkov/fix-set-arg-local-accessor branch May 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexeySachkov @pvchupin @steffenlarsen