Skip to content

[NFC][SYCL] Unify single/multi reduction_parallel_for for nd_range #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

aelovikov-intel
Copy link
Contributor

This also directs reduction::strategy::multi through the dispatcher for other single-reduction strategies, making it possible to invoke vararg implementation for a single reduction (through internal APIs, of course).

This also directs reduction::strategy::multi through the dispatcher for
other single-reduction strategies, making it possible to invoke vararg
implementation for a single reduction (through internal APIs, of
course).
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Small comment.

@aelovikov-intel aelovikov-intel marked this pull request as draft November 11, 2022 17:14
@aelovikov-intel aelovikov-intel marked this pull request as ready for review November 11, 2022 17:14
@steffenlarsen steffenlarsen merged commit 43d6af7 into intel:sycl Nov 15, 2022
@aelovikov-intel aelovikov-intel deleted the reduction2 branch April 7, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants