Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Add a test targeting internal reduction APIs #1373

Merged
merged 6 commits into from
Nov 24, 2022

Conversation

aelovikov-intel
Copy link

That way we can bypass strategy selection and test any of them with the same type/operation.

@aelovikov-intel
Copy link
Author

I think this would make some existing tests redundant but I'm not comfortable in removing any of them yet.

@aelovikov-intel
Copy link
Author

/verify with intel/llvm#7405

That way we can bypass strategy selection and test any of them with the
same type/operation.
@aelovikov-intel aelovikov-intel marked this pull request as ready for review November 23, 2022 20:27
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner November 23, 2022 20:27
@aelovikov-intel
Copy link
Author

Failure on

SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp

is being tracked in internal bug report.

Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future I would love to see these exposed as properties so users can take control of it too, but for now I think this looks good.

@steffenlarsen steffenlarsen merged commit 4b9e726 into intel:intel Nov 24, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
That way we can bypass strategy selection and test any of them with the
same type/operation.
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…suite#1373)

That way we can bypass strategy selection and test any of them with the
same type/operation.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants