This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] Add a test targeting internal reduction APIs #1373
Merged
steffenlarsen
merged 6 commits into
intel:intel
from
aelovikov-intel:reduction-internal-test
Nov 24, 2022
Merged
[SYCL] Add a test targeting internal reduction APIs #1373
steffenlarsen
merged 6 commits into
intel:intel
from
aelovikov-intel:reduction-internal-test
Nov 24, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this would make some existing tests redundant but I'm not comfortable in removing any of them yet. |
2756fc2
to
8578d94
Compare
/verify with intel/llvm#7405 |
That way we can bypass strategy selection and test any of them with the same type/operation.
8578d94
to
ebc797d
Compare
Hopefully would help investigate CI timeouts. Also, can be kept in the final version.
This reverts commit 60c1b68.
Failure on SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp is being tracked in internal bug report. |
steffenlarsen
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future I would love to see these exposed as properties so users can take control of it too, but for now I think this looks good.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
That way we can bypass strategy selection and test any of them with the same type/operation.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…suite#1373) That way we can bypass strategy selection and test any of them with the same type/operation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we can bypass strategy selection and test any of them with the same type/operation.