This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] End-to-end tests for queue shortcut functions #1362
Merged
AlexeySachkov
merged 6 commits into
intel:intel
from
andylshort:alamzeds/queue-shortcuts-sycl2020
Nov 17, 2022
Merged
[SYCL] End-to-end tests for queue shortcut functions #1362
AlexeySachkov
merged 6 commits into
intel:intel
from
andylshort:alamzeds/queue-shortcuts-sycl2020
Nov 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/verify with intel/llvm#7266 |
romanovvlad
reviewed
Nov 4, 2022
It's illegal to access data stored while the controlling sycl::buffer is still alive, so I moved the sycl-based accesses to their own scope.
intel/llvm#7266 has now been merged into the sycl branch so this should now build in CI. |
You need to restart CI for that. You can either close and reopen the PR or simply merge |
AlexeySachkov
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
romanovvlad
approved these changes
Nov 17, 2022
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
[SYCL] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION (intel#1311)
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-to-end tests for each of the 7 explicit copy queue shortcut functions defined in Table 29 of Section 4.6.5.2 of the specification.
This PR is contingent upon intel/llvm#7266 being accepted and merged.