Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] End-to-end tests for queue shortcut functions #1362

Merged

Conversation

andylshort
Copy link

@andylshort andylshort commented Nov 4, 2022

End-to-end tests for each of the 7 explicit copy queue shortcut functions defined in Table 29 of Section 4.6.5.2 of the specification.

This PR is contingent upon intel/llvm#7266 being accepted and merged.

@andylshort andylshort requested a review from a team as a code owner November 4, 2022 14:07
@andylshort andylshort requested review from bso-intel and a team November 4, 2022 14:07
@andylshort
Copy link
Author

/verify with intel/llvm#7266

Lamzed-Short, Andrew added 2 commits November 7, 2022 03:39
It's illegal to access data stored while the controlling sycl::buffer is
still alive, so I moved the sycl-based accesses to their own scope.
@andylshort
Copy link
Author

intel/llvm#7266 has now been merged into the sycl branch so this should now build in CI.

@AlexeySachkov
Copy link

intel/llvm#7266 has now been merged into the sycl branch so this should now build in CI.

You need to restart CI for that. You can either close and reopen the PR or simply merge intel branch into your PR to introduce an update here

Copy link

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@AlexeySachkov AlexeySachkov merged commit 5d63e2a into intel:intel Nov 17, 2022
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
[SYCL] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION (intel#1311)
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants