This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TRIX_VERSION Signed-off-by: Sidorov, Dmitry <[email protected]>
dkhaldi
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/verify with intel/llvm#6957 |
Ping @cperkinsintel or @intel/llvm-reviewers-runtime for review. |
For CUDA tests: was able to compile them manually, but execution requires something like A1000. But compilation should be good enough for testing, since it's a compilation macro change that switches different interfaces. |
@cperkinsintel @intel/llvm-reviewers-runtime could you please check it? We need this patch and intel/llvm#6957 to be merged ASAP |
cperkinsintel
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pvchupin
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 11, 2022
Default SYCL_EXT_ONEAPI_MATRIX to 1 Added SYCL_EXT_ONEAPI_MATRIX_VERSION to differentiate API versions. Only add 'Use' parameter if testing macro SYCL_EXT_ONEAPI_MATRIX_VERSION = 2 is defined. Test change: intel/llvm-test-suite#1311 Signed-off-by: Sidorov, Dmitry [email protected]
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…SION (intel#1311) [SYCL][Matrix] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION Related to intel/llvm#6957 Signed-off-by: Sidorov, Dmitry <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…SION (intel#1311) [SYCL][Matrix] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION Related to intel/llvm#6957 Signed-off-by: Sidorov, Dmitry <[email protected]>
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
[SYCL] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION (intel#1311)
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…SION (intel/llvm-test-suite#1311) [SYCL][Matrix] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION Related to intel#6957 Signed-off-by: Sidorov, Dmitry <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sidorov, Dmitry [email protected]