Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION #1311

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

MrSidims
Copy link

@MrSidims MrSidims commented Oct 6, 2022

Signed-off-by: Sidorov, Dmitry [email protected]

Copy link

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrSidims
Copy link
Author

MrSidims commented Oct 6, 2022

/verify with intel/llvm#6957

@pvchupin
Copy link

Ping @cperkinsintel or @intel/llvm-reviewers-runtime for review.

@MrSidims
Copy link
Author

For CUDA tests: was able to compile them manually, but execution requires something like A1000. But compilation should be good enough for testing, since it's a compilation macro change that switches different interfaces.

@MrSidims
Copy link
Author

@cperkinsintel @intel/llvm-reviewers-runtime could you please check it? We need this patch and intel/llvm#6957 to be merged ASAP

Copy link

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pvchupin pushed a commit to intel/llvm that referenced this pull request Oct 11, 2022
Default SYCL_EXT_ONEAPI_MATRIX to 1

Added SYCL_EXT_ONEAPI_MATRIX_VERSION to differentiate API versions.

Only add 'Use' parameter if testing macro SYCL_EXT_ONEAPI_MATRIX_VERSION = 2
is defined.

Test change: intel/llvm-test-suite#1311

Signed-off-by: Sidorov, Dmitry [email protected]
@pvchupin pvchupin merged commit decb682 into intel:intel Oct 11, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
…SION (intel#1311)

[SYCL][Matrix] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION

Related to intel/llvm#6957

Signed-off-by: Sidorov, Dmitry <[email protected]>
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
…SION (intel#1311)

[SYCL][Matrix] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION

Related to intel/llvm#6957

Signed-off-by: Sidorov, Dmitry <[email protected]>
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
[SYCL] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION (intel#1311)
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…SION (intel/llvm-test-suite#1311)

[SYCL][Matrix] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION

Related to intel#6957

Signed-off-by: Sidorov, Dmitry <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants