Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][Fusion] Test fusion scheduler integration #1416

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

sommerlukas
Copy link

Test integration of kernel fusion into the SYCL runtime scheduler.

Check that cancellation of the fusion happens if required by synchronization rules, as described in the extension proposal.

Spec: intel/llvm#7098
Implementation: intel/llvm#7531

Signed-off-by: Lukas Sommer [email protected]

@sommerlukas
Copy link
Author

This PR is marked as draft because it needs to be rebased after #1404 has been merged.

@sommerlukas sommerlukas self-assigned this Nov 28, 2022
@sommerlukas sommerlukas force-pushed the kernel-fusion/third-patch branch from a074ce6 to c162b1b Compare November 28, 2022 16:03
@sommerlukas sommerlukas marked this pull request as ready for review November 28, 2022 16:04
@sommerlukas sommerlukas requested a review from a team as a code owner November 28, 2022 16:04
@sommerlukas
Copy link
Author

Rebased and marked as ready for review now that #1404 has been merged.

@dm-vodopyanov
Copy link

/verify with intel/llvm#7531

@bader
Copy link

bader commented Dec 7, 2022

Ping @dm-vodopyanov and @intel/llvm-reviewers-runtime.

@sommerlukas
Copy link
Author

Ping @dm-vodopyanov and @intel/llvm-reviewers-runtime

@sommerlukas
Copy link
Author

/verify with intel/llvm#7831

@sommerlukas
Copy link
Author

Ping @dm-vodopyanov and @intel/llvm-reviewers-runtime.

@sommerlukas
Copy link
Author

@intel/llvm-gatekeepers Can someone please merge this for me, as I'm not authorized.

@dm-vodopyanov
Copy link

/verify with intel/llvm#8051

@dm-vodopyanov
Copy link

@intel/llvm-gatekeepers Can someone please merge this for me, as I'm not authorized.

Need to test the PR with latest intel/llvm before merging. @sommerlukas can you please update the branch with latest changes from intel/llvm to trigger Jenkins/pre-ci-* checks?

@sommerlukas sommerlukas force-pushed the kernel-fusion/third-patch branch from 7a3de20 to 7bb1d46 Compare January 19, 2023 14:18
@sommerlukas
Copy link
Author

@dm-vodopyanov: I've rebased this PR on top of intel/llvm-test-suite, is that what you had in mind?

@dm-vodopyanov
Copy link

@dm-vodopyanov: I've rebased this PR on top of intel/llvm-test-suite, is that what you had in mind?

Yes, thank you!

@dm-vodopyanov
Copy link

@sommerlukas there are failures in pre-commit, can you please take a look?
OpenCL Linux:

[2023-01-19T14:43:48.006Z]   SYCL :: KernelFusion/sync_usm_mem_op.cpp

Level Zero Linux:

[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_acc_mem_op.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_buffer_destruction.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_event_wait.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_host_accessor.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_host_task.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_queue_destruction.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_queue_wait.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_second_queue.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_two_queues_event_dep.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_two_queues_requirement.cpp
[2023-01-19T15:03:28.719Z]   SYCL :: KernelFusion/sync_usm_mem_op.cpp

OpenCL Windows:

[2023-01-19T15:10:22.977Z]   SYCL :: KernelFusion/sync_two_queues_requirement.cpp

Level Zero Windows:

[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_acc_mem_op.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_buffer_destruction.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_event_wait.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_host_accessor.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_host_task.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_queue_destruction.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_queue_wait.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_second_queue.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_two_queues_event_dep.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_two_queues_requirement.cpp
[2023-01-19T15:37:19.164Z]   SYCL :: KernelFusion/sync_usm_mem_op.cpp

@sommerlukas sommerlukas force-pushed the kernel-fusion/third-patch branch from 7bb1d46 to 6351fdb Compare January 20, 2023 15:05
Test integration of kernel fusion into the SYCL runtime scheduler.
Check that cancellation of the fusion happens if required by
synchronization rules.

Signed-off-by: Lukas Sommer <[email protected]>
@sommerlukas sommerlukas force-pushed the kernel-fusion/third-patch branch from 6351fdb to 0364261 Compare January 20, 2023 17:18
@sommerlukas
Copy link
Author

@dm-vodopyanov Thanks for the summary. The errors should be fixed now, all checks have passed.

@dm-vodopyanov dm-vodopyanov merged commit fd1af4d into intel:intel Jan 23, 2023
@dm-vodopyanov
Copy link

@sommerlukas Thanks!

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Test integration of kernel fusion into the SYCL runtime scheduler.
    
Check that cancellation of the fusion happens if required by synchronization rules, as described in the [extension proposal](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_codeplay_kernel_fusion.asciidoc#synchronization-in-the-sycl-application).

Spec: intel/llvm#7098
Implementation: intel/llvm#7531

Signed-off-by: Lukas Sommer <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…te#1416)

Test integration of kernel fusion into the SYCL runtime scheduler.
    
Check that cancellation of the fusion happens if required by synchronization rules, as described in the [extension proposal](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_codeplay_kernel_fusion.asciidoc#synchronization-in-the-sycl-application).

Spec: intel#7098
Implementation: intel#7531

Signed-off-by: Lukas Sommer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants