[SYCL][Fusion] Scheduler support for kernel fusion #7531
Conversation
|
Tests for this PR are in intel/llvm-test-suite#1416 |
|
/verify with intel/llvm-test-suite#1416 |
There was a problem hiding this comment.
Generally looks good, but since it touches the graph-builder and scheduler I would like @sergey-semenov's eyes on it too.
sommerlukas
force-pushed
the
kernel-fusion/third-patch
branch
from
2af8527 to
b589343
Compare
@sergey-semenov, ping. |
sommerlukas
force-pushed
the
kernel-fusion/third-patch
branch
2 times, most recently
from
4c5095e to
e271e60
Compare
sommerlukas
force-pushed
the
kernel-fusion/third-patch
branch
from
1e63bdb to
793b19b
Compare
|
@sergey-semenov Thank you very much for your review and feedback! I've addressed it in the latest commit.
I have now added a unit-test (as part of the The scheduler integration is also tested by a number of application tests in intel/llvm-test-suite#1416. |
sommerlukas
force-pushed
the
kernel-fusion/third-patch
branch
from
704bab3 to
e0430cd
Compare
|
@sommerlukas, please fix conflicts |
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
force-pushed
the
kernel-fusion/third-patch
branch
from
e0430cd to
5bdbb12
Compare
Sorry for the delay, I needed to wait for #7794 and #7798 to be merged, because without those, tests were failing locally for me. The rebase is done now. @pvchupin, @steffenlarsen or @intel/llvm-gatekeepers can you please merge this now? |
Test integration of kernel fusion into the SYCL runtime scheduler.
Check that cancellation of the fusion happens if required by synchronization rules, as described in the [extension proposal](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_codeplay_kernel_fusion.asciidoc#synchronization-in-the-sycl-application).
Spec: intel/llvm#7098
Implementation: intel/llvm#7531
Signed-off-by: Lukas Sommer <[email protected]>
Test integration of kernel fusion into the SYCL runtime scheduler.
Check that cancellation of the fusion happens if required by synchronization rules, as described in the [extension proposal](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_codeplay_kernel_fusion.asciidoc#synchronization-in-the-sycl-application).
Spec: intel#7098
Implementation: intel#7531
Signed-off-by: Lukas Sommer <[email protected]>
…te#1416) Test integration of kernel fusion into the SYCL runtime scheduler. Check that cancellation of the fusion happens if required by synchronization rules, as described in the [extension proposal](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_codeplay_kernel_fusion.asciidoc#synchronization-in-the-sycl-application). Spec: intel#7098 Implementation: intel#7531 Signed-off-by: Lukas Sommer <[email protected]>
This is the third patch in a series of patches to add an implementation of the kernel fusion extension. We have split the implementation into multiple patches to make them more easy to review. This patch integrates the kernel fusion extension into the SYCL runtime scheduler.
Next to collecting the kernels submitted while in fusion mode in the fusion list associated with the queue, the integration into the scheduler is also responsible for detecting the synchronization scenarios. Various scenarios, such as buffer destruction or event wait, require fusion to be aborted early. The full list of scenarios is available in the extension proposal.
A high-level description of the integration into the scheduler can be found in the design document.
This PR can be reviewed and merged independently of #7465.
Signed-off-by: Lukas Sommer [email protected]