-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] Extend coverage of USM memcpy, fill, and memset #144
[SYCL] Extend coverage of USM memcpy, fill, and memset #144
Conversation
Extends the coverage of the USM operations memcpy, fill, and memset by testing for both regular and aligned allocations for the host, shared, and device allocation types. This also migrates the USM allocator container test. Signed-off-by: Steffen Larsen <[email protected]>
3125903
to
c1c3b20
Compare
The on-device tests have been migrated to the Intel LLVM test suite: intel/llvm-test-suite#144 Signed-off-by: Steffen Larsen <[email protected]>
Pre-CI failures do not appear to be related to these changes. |
Splits sycl/test/extensions/usm.cpp into 2 new test files: * sycl/test/extensions/usm/usm_alloc_utility.cpp * sycl/test/extensions/usm/usm_allocator.cpp The on-device tests have been migrated to the Intel LLVM test suite: intel/llvm-test-suite#144 Signed-off-by: Steffen Larsen <[email protected]>
@DenisBakhvalov, @kbobrovs, ESIMD tests are failing for this PR. Can you do something to avoid such false alarms, please? |
@fadeeval, @DenisBakhvalov, @kbobrovs I have disabled the test in #146 to avoid impact o CI |
@bader @vladimirlaz, I think those were real issues. @fveselov, please take a look and reenable the tests once the problem is identified. |
There is no way this patch can introduce them. Right? |
I think they didn't show up in the Pre-CI. According to @vladimirlaz, they passed occasionally (once per 10-20 runs). In pre-CI, we were lucky enough to get them passed. |
I wish to be that lucky. Usually, if I have a test which fails once per 10-20 runs it fails in CI on every run. :) |
Sure, I was planning to debug noinline_call_from_func, will take a look at fp_in_select as well. |
…st-suite#144) Extends the coverage of the USM operations memcpy, fill, and memset by testing for both regular and aligned allocations for the host, shared, and device allocation types. This also migrates the USM allocator container test. Signed-off-by: Steffen Larsen <[email protected]>
Extends the coverage of the USM operations memcpy, fill, and memset by
testing for both regular and aligned allocations for the host, shared,
and device allocation types.
Migrated from: intel/llvm#3189