Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Extend coverage of USM memcpy, fill, and memset #144

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

steffenlarsen
Copy link

Extends the coverage of the USM operations memcpy, fill, and memset by
testing for both regular and aligned allocations for the host, shared,
and device allocation types.

Migrated from: intel/llvm#3189

Extends the coverage of the USM operations memcpy, fill, and memset by
testing for both regular and aligned allocations for the host, shared,
and device allocation types.

This also migrates the USM allocator container test.

Signed-off-by: Steffen Larsen <[email protected]>
@steffenlarsen steffenlarsen force-pushed the steffen/extend_usm_coverage branch from 3125903 to c1c3b20 Compare February 16, 2021 13:58
steffenlarsen pushed a commit to steffenlarsen/llvm that referenced this pull request Feb 16, 2021
The on-device tests have been migrated to the Intel LLVM test suite:
intel/llvm-test-suite#144

Signed-off-by: Steffen Larsen <[email protected]>
@steffenlarsen
Copy link
Author

Pre-CI failures do not appear to be related to these changes.

bader pushed a commit to intel/llvm that referenced this pull request Feb 17, 2021
Splits sycl/test/extensions/usm.cpp into 2 new test files:
* sycl/test/extensions/usm/usm_alloc_utility.cpp
* sycl/test/extensions/usm/usm_allocator.cpp

The on-device tests have been migrated to the Intel LLVM test suite:
intel/llvm-test-suite#144

Signed-off-by: Steffen Larsen <[email protected]>
@bader
Copy link

bader commented Feb 17, 2021

Pre-CI failures do not appear to be related to these changes.

@DenisBakhvalov, @kbobrovs, ESIMD tests are failing for this PR. Can you do something to avoid such false alarms, please?

@vladimirlaz
Copy link

@fadeeval, @DenisBakhvalov, @kbobrovs I have disabled the test in #146 to avoid impact o CI
Could you please fix test issue an enable it back?

@DenisBakhvalov
Copy link

@bader @vladimirlaz, I think those were real issues. @fveselov, please take a look and reenable the tests once the problem is identified.

@bader
Copy link

bader commented Feb 17, 2021

@bader @vladimirlaz, I think those were real issues. @fveselov, please take a look and reenable the tests once the problem is identified.

There is no way this patch can introduce them. Right?
If so, the question is how they appear? Are there failures sporadic or someone ignored pre-commit failures?

@DenisBakhvalov
Copy link

@bader @vladimirlaz, I think those were real issues. @fveselov, please take a look and reenable the tests once the problem is identified.

There is no way this patch can introduce them. Right?
If so, the question is how they appear? Are there failures sporadic or someone ignored pre-commit failures?

I think they didn't show up in the Pre-CI. According to @vladimirlaz, they passed occasionally (once per 10-20 runs). In pre-CI, we were lucky enough to get them passed.

@bader
Copy link

bader commented Feb 17, 2021

I think they didn't show up in the Pre-CI. According to @vladimirlaz, they passed occasionally (once per 10-20 runs). In pre-CI, we were lucky enough to get them passed.

I wish to be that lucky. Usually, if I have a test which fails once per 10-20 runs it fails in CI on every run. :)

@fveselov
Copy link

@bader @vladimirlaz, I think those were real issues. @fveselov, please take a look and reenable the tests once the problem is identified.

Sure, I was planning to debug noinline_call_from_func, will take a look at fp_in_select as well.

@vladimirlaz vladimirlaz merged commit 0e1c027 into intel:intel Feb 18, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…st-suite#144)

Extends the coverage of the USM operations memcpy, fill, and memset by
testing for both regular and aligned allocations for the host, shared,
and device allocation types.

This also migrates the USM allocator container test.

Signed-off-by: Steffen Larsen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants