-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL] Extend USM testing #3189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Splits sycl/test/extensions/usm.cpp into 3 new test files: * sycl/test/extensions/usm/usm_alloc_utility.cpp * sycl/test/extensions/usm/usm_allocator.cpp * sycl/test/extensions/usm/usm_allocator_container.cpp Also adds tests for the USM operations for fill, memcpy, and memset. Signed-off-by: Steffen Larsen <[email protected]>
Signed-off-by: Steffen Larsen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests which assume execution of device code should be moved temporarily to sycl/test/on-device and to https://github.com/intel/llvm-test-suite as long-term location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve to let CI testing start
Signed-off-by: Steffen Larsen <[email protected]>
I've moved the tests that execute on device to sycl/test/on-device/extensions/usm/. On that note, I believe the implementation of these functions are in line with SYCL 2020, so should I move them out of the extensions folders? |
Signed-off-by: Steffen Larsen <[email protected]>
@steffenlarsen It looks like the PR has only test changes. So could you please split it in 2. The test in on-device directory should be moved to https://github.com/intel/llvm-test-suite/ (see CONTRIBUTING.md for details) |
The on-device tests have been migrated to the Intel LLVM test suite: intel/llvm-test-suite#144 Signed-off-by: Steffen Larsen <[email protected]>
The on-device tests have been migrated to the Intel LLVM test suite. PR for this: intel/llvm-test-suite#144 |
Splits sycl/test/extensions/usm.cpp into 3 test files:
Also adds tests for the USM operations
fill
,memcpy
, andmemset
.