Skip to content

[SYCL] Extend USM testing #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Conversation

steffenlarsen
Copy link
Contributor

Splits sycl/test/extensions/usm.cpp into 3 test files:

  • sycl/test/extensions/usm/usm_alloc_utility.cpp
  • sycl/test/extensions/usm/usm_allocator.cpp
  • sycl/test/extensions/usm/usm_allocator_container.cpp

Also adds tests for the USM operations fill, memcpy, and memset.

Splits sycl/test/extensions/usm.cpp into 3 new test files:
* sycl/test/extensions/usm/usm_alloc_utility.cpp
* sycl/test/extensions/usm/usm_allocator.cpp
* sycl/test/extensions/usm/usm_allocator_container.cpp

Also adds tests for the USM operations for fill, memcpy, and memset.

Signed-off-by: Steffen Larsen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner February 9, 2021 12:55
Signed-off-by: Steffen Larsen <[email protected]>
@bader bader requested a review from jbrodman February 12, 2021 10:35
Copy link
Contributor

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests which assume execution of device code should be moved temporarily to sycl/test/on-device and to https://github.com/intel/llvm-test-suite as long-term location.

vladimirlaz
vladimirlaz previously approved these changes Feb 15, 2021
Copy link
Contributor

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to let CI testing start

@vladimirlaz vladimirlaz dismissed their stale review February 15, 2021 06:45

revert approve

@steffenlarsen
Copy link
Contributor Author

The tests which assume execution of device code should be moved temporarily to sycl/test/on-device and to https://github.com/intel/llvm-test-suite as long-term location.

I've moved the tests that execute on device to sycl/test/on-device/extensions/usm/. On that note, I believe the implementation of these functions are in line with SYCL 2020, so should I move them out of the extensions folders?

Signed-off-by: Steffen Larsen <[email protected]>
vladimirlaz
vladimirlaz previously approved these changes Feb 15, 2021
@vladimirlaz
Copy link
Contributor

@steffenlarsen It looks like the PR has only test changes. So could you please split it in 2. The test in on-device directory should be moved to https://github.com/intel/llvm-test-suite/ (see CONTRIBUTING.md for details)

The on-device tests have been migrated to the Intel LLVM test suite:
intel/llvm-test-suite#144

Signed-off-by: Steffen Larsen <[email protected]>
@steffenlarsen
Copy link
Contributor Author

The on-device tests have been migrated to the Intel LLVM test suite. PR for this: intel/llvm-test-suite#144

@bader bader merged commit f9241e0 into intel:sycl Feb 17, 2021
@steffenlarsen steffenlarsen deleted the steffen/expand_usm_tests branch December 6, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants