Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL-MLIR] XFAIL other lits failed on other platforms #1538

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

whitneywhtsang
Copy link

@whitneywhtsang whitneywhtsang commented Jan 24, 2023

Some tests were missing from the xfail list in #1536.

Signed-off-by: Tsang, Whitney [email protected]

@whitneywhtsang whitneywhtsang added the sycl-mlir Pull requests or issues for sycl-mlir branch label Jan 24, 2023
@whitneywhtsang whitneywhtsang self-assigned this Jan 24, 2023
@victor-eds
Copy link

Are these tests passing on CPU but failing on GPU?

@victor-eds
Copy link

Are these tests passing on CPU but failing on GPU?

Okey, I see now. If these failures depend on the platform, we might need different XFail lists for different platforms. If we merge this change, the tests won't pass for OCL x64, right?

@whitneywhtsang
Copy link
Author

Are these tests passing on CPU but failing on GPU?

Okey, I see now. If these failures depend on the platform, we might need different XFail lists for different platforms. If we merge this change, the tests won't pass for OCL x64, right?

I ran this updated list on my machine, and is still passing, likely all because they are unsupported on cpu.
I checked some of them, and they are indeed marked with UNSUPPORTED: cpu, or don't have run line for CPU.

@whitneywhtsang
Copy link
Author

Updated the list to only add the tests that fail or unsupported on all platforms our buildbots run.
The buildbot would still be failing now, as there are still tests that pass on some platforms and fail on the others.

@@ -262,8 +273,8 @@ SubGroup/shuffle.cpp
SubGroup/sub_group_as.cpp
SubGroup/sub_group_as_vec.cpp
SubGroup/sub_groups_sycl2020.cpp
SubGroup/vote.cpp
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass on all 3 buildbots, can remove from the xfail list.

Comment on lines +130 to +133
DeviceGlobal/device_global_arrow.cpp
DeviceGlobal/device_global_device_only.cpp
DeviceGlobal/device_global_operator_passthrough.cpp
DeviceGlobal/device_global_subscript.cpp
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsupported on x64. Failed on GEN9.

Comment on lines +157 to +158
ESIMD/dword_atomic_cmpxchg.cpp
ESIMD/dword_atomic_smoke.cpp
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsupported on x64. Failed on GEN9.

Comment on lines +187 to +188
Plugin/interop-level-zero-buffer-multi-dim.cpp
Plugin/level_zero_track_indirect_access_memory.cpp
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsupported on OCL GEN9 and x64. Failed on L0 GEN9.

@@ -216,8 +224,11 @@ Reduction/reduction_usm_dw.cpp
Reduction/regression_after_pr_6343.cpp
Regression/atomic_load.cpp
Regression/group.cpp
Regression/half_operators.cpp
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsupported on x64. Failed on GEN9.

Comment on lines +230 to +231
Regression/reduction_resource_leak_dw.cpp
Regression/reduction_resource_leak_usm.cpp
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsupported on OCL GEN9 and x64. Failed on L0 GEN9.

SubGroupMask/Basic.cpp
SubGroupMask/GroupSize.cpp
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsupported on x64. Failed on GEN9.

@victor-eds
Copy link

Oh, great! We should merge in that case. Thanks!

@whitneywhtsang whitneywhtsang merged commit 0e4e6f4 into sycl-mlir Jan 24, 2023
@whitneywhtsang whitneywhtsang deleted the xfail_update branch January 24, 2023 15:19
whitneywhtsang added a commit that referenced this pull request Jan 25, 2023
Some tests were missing from the xfail list in #1536.

Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang added a commit that referenced this pull request Jan 27, 2023
Some tests were missing from the xfail list in #1536.

Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang added a commit that referenced this pull request Feb 17, 2023
Some tests were missing from the xfail list in #1536.

Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang added a commit that referenced this pull request Mar 1, 2023
Some tests were missing from the xfail list in #1536.

Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang added a commit that referenced this pull request Mar 27, 2023
Some tests were missing from the xfail list in #1536.

Signed-off-by: Tsang, Whitney <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sycl-mlir Pull requests or issues for sycl-mlir branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants