Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] XFAIL spec_constants_after_link for HIP #1572

Merged
merged 1 commit into from
Feb 6, 2023
Merged

[SYCL] XFAIL spec_constants_after_link for HIP #1572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions SYCL/KernelAndProgram/spec_constants_after_link.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
// RUN: %GPU_RUN_PLACEHOLDER %t.out
// FIXME: ACC devices use emulation path, which is not yet supported

// HIP backend does not currently implement linking.
// XFAIL: hip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// XFAIL: hip
// UNSUPPORTED: hip

?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against going with UNSUPPORTED, but since this is a consistent failure due to missing functionality, XFAIL has the added benefit of telling us when the test is ready to be enabled, so we don't miss enabling it. It does of course come with the downside of needing a merge of both test-suite changes and intel/llvm changes being merged at the same time, causing the problem with failing tests in the test-suite CI.


// This test checks that specialization constant information is available on
// kernel bundles produced by sycl::link.

Expand Down