[SYCL] XFAIL spec_constants_after_link for HIP #1572
Conversation
The HIP backend does not currently implement piProgramLink and as such spec_constants_after_link is expected to fail for it. Signed-off-by: Larsen, Steffen <[email protected]>
| @@ -3,6 +3,9 @@ | |||
| // RUN: %GPU_RUN_PLACEHOLDER %t.out | |||
| // FIXME: ACC devices use emulation path, which is not yet supported | |||
|
|
|||
| // HIP backend does not currently implement linking. | |||
| // XFAIL: hip | |||
There was a problem hiding this comment.
| // XFAIL: hip | |
| // UNSUPPORTED: hip |
?
There was a problem hiding this comment.
I'm not against going with UNSUPPORTED, but since this is a consistent failure due to missing functionality, XFAIL has the added benefit of telling us when the test is ready to be enabled, so we don't miss enabling it. It does of course come with the downside of needing a merge of both test-suite changes and intel/llvm changes being merged at the same time, causing the problem with failing tests in the test-suite CI.
|
@intel/llvm-reviewers-runtime, please, review ASAP. This issue impacts pre-commit validation in intel/llvm repository. |
Done, please merge. |
The HIP backend does not currently implement piProgramLink and as such spec_constants_after_link is expected to fail for it. Signed-off-by: Larsen, Steffen <[email protected]>
…#1572) The HIP backend does not currently implement piProgramLink and as such spec_constants_after_link is expected to fail for it. Signed-off-by: Larsen, Steffen <[email protected]>
The HIP backend does not currently implement piProgramLink and as such spec_constants_after_link is expected to fail for it.