[SYCL][Clang] Fix annotations applied to integer fields #8198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to incorrect conflict resolution between 8e13852 (intel/llvm customization) and https://reviews.llvm.org/D138722 clang started emitting annotations applied to integer class/struct fields incorrectly. Incorrect overload of llvm.ptr.annotation intrinsic was picked up and this resulted in invalid IR emission. This patch restores behaviour introduced by 8e13852. The existing test added for 8e13852 didn't catch the problem since it is modified upstream test `CodeGen/annotations-field.c` which doesn't test typed pointers.
smanna12
approved these changes
Feb 3, 2023
premanandrao
reviewed
Feb 3, 2023
premanandrao
approved these changes
Feb 3, 2023
|
Hip failure is unrelated. The corresponding test is being disabled in intel/llvm-test-suite#1572 . |
| struct foo f; | ||
| f.v = 1; | ||
| // CHECK: getelementptr inbounds %struct.foo, %struct.foo addrspace(4)* %{{.*}}, i32 0, i32 0 | ||
| // CHECK-NEXT: call i32 addrspace(4)* @llvm.ptr.annotation.p4i32.p1i8({{.*}}str{{.*}}str{{.*}}i32 14, i8 addrspace(1)* null) |
There was a problem hiding this comment.
Is this str a variable holding annotation?. Also what does 14 here refer to?
Just curious and for my own learning
There was a problem hiding this comment.
Yes, str is a variable with annotation string. 14 seems to be a line of code on which annotation happened.
|
@intel/llvm-gatekeepers , please merge as soon as possible. This is a blocker for the downstream. |
|
HIP Failed Tests (1): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to incorrect conflict resolution between 8e13852 (intel/llvm customization) and https://reviews.llvm.org/D138722 clang started emitting annotations applied to integer class/struct fields incorrectly. Incorrect overload of llvm.ptr.annotation intrinsic was picked up and this resulted in invalid IR emission. This patch restores behavior introduced by 8e13852.
The existing test added for 8e13852 didn't catch the problem since it is modified upstream test
CodeGen/annotations-field.cwhich doesn't test typed pointers.