[SYCL] Refactor program build and cache #8193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to help device_global find associated programs in the cache, the way the program manager and the cache interacts needs a refactoring. This commit makes this refactoring. Additionally this adds the notion of a "common key" (CommonProgramKeyT) representing the common parts of the full cache key shared between builds of the same program on the same device, excluding specializations such as specialization constants and compilation options. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
…and_cache_refactor
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
requested review from
romanovvlad,
sergey-semenov and
aelovikov-intel
|
Tagging @bader for awareness. |
sergey-semenov
approved these changes
Feb 3, 2023
aelovikov-intel
approved these changes
Feb 3, 2023
|
HIP Failed Tests (1): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to help device_global find associated programs in the cache, the way the program manager and the cache interacts needs a refactoring. This commit makes this refactoring.
Additionally this adds the notion of a "common key" (CommonProgramKeyT) representing the common parts of the full cache key shared between builds of the same program on the same device, excluding specializations such as specialization constants and compilation options.