Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[ESIMD] Enable the test imulh_umulh.cpp #1594

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

v-klochkov
Copy link

The test was disabled due to false-alarm. The cases/PRs reporting this test as 'unrelated fail' used old compiler with new test.

All such PRs had CI runs with the test failed at compilation.

Even though both the PR and LIT tests were merged at same hour, the compiled used by CI was still old, but the test was new. PR: intel/llvm#8176
PR-LIT: #1566

Signed-off-by: Vyacheslav N Klochkov [email protected]

The test was disabled due to false-alarm. The cases/PRs reporting
this test as 'unrelated fail' used _old_ compiler with _new_ test.

All such PRs had CI runs with the test failed at compilation.

Even though both the PR and LIT tests were merged at same hour,
the compiled used by CI was still old, but the test was new.
PR: intel/llvm#8176
PR-LIT: intel#1566

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
@v-klochkov v-klochkov requested a review from a team as a code owner February 14, 2023 02:20
@v-klochkov v-klochkov requested a review from bader February 14, 2023 02:20
@v-klochkov
Copy link
Author

@bader - IMO, it was a false-alarm. After some additional investigation the test doesn't seem flaky.
There were 4 PRs complaining about this test fail as unrelated. In those PRs CI reported compilation error

In those cases when the test fails it says:

/__w/llvm/llvm/toolchain/bin/../include/sycl/ext/intel/experimental/esimd/math.hpp:424:12: error: no matching function for call to '__esimd_umulh'
    return __esimd_umulh(Src0.data(), Src1.data());
           ^~~~~~~~~~~~~

That tells me that the new test was tested with old compiler because the call of__esimd_umulh at line 424
was done in old compiler: https://github.com/intel/llvm/pull/8176/files#diff-26ef7db7487d5ee7f82b57f6a4c5a4e20e82786e94a19c1b0d4cba460f94924bL424

@v-klochkov
Copy link
Author

Fails on 2 tests are unrelated to this PR:
SYCL :: OneapiDeviceSelector/case_sensitivity.cpp
SYCL :: Reduction/reduction_ctor.cpp

@v-klochkov v-klochkov merged commit 15afe1e into intel:intel Feb 16, 2023
@v-klochkov v-klochkov deleted the esimd_imulh_lit branch February 16, 2023 21:45
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
CMPLRTST-18835: Skip esimd_preemption on ATSM
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
The test was disabled due to false-alarm. The cases/PRs reporting
this test as 'unrelated fail' used _old_ compiler with _new_ test.

All such PRs had CI runs with the test failed at compilation.

Even though both the PR and LIT tests were merged at same hour,
the compiled used by CI was still old, but the test was new.
PR: intel/llvm#8176
PR-LIT: intel#1566

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
The test was disabled due to false-alarm. The cases/PRs reporting
this test as 'unrelated fail' used _old_ compiler with _new_ test.

All such PRs had CI runs with the test failed at compilation.

Even though both the PR and LIT tests were merged at same hour,
the compiled used by CI was still old, but the test was new.
PR: intel#8176
PR-LIT: intel/llvm-test-suite#1566

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants