Skip to content

[ESIMD] Fix imul() implementation and allow imul() for 2 vectors #8176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

v-klochkov
Copy link
Contributor

@v-klochkov v-klochkov commented Feb 2, 2023

Previously the operation supported only vector-by-scalar, scalar-by-vector and scalar-by-scalar multiplication. This patch enables vector-by-vector multiplication as well.

The corresponding LIT test PR: intel/llvm-test-suite#1566

Signed-off-by: Vyacheslav N Klochkov [email protected]

Previously the operation supported only vector-by-scalar, scalar-by-vector
and scalar-by-scalar multiplication. This patch enables vector-by-vector
multiplication as well.

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
@v-klochkov v-klochkov requested a review from a team as a code owner February 2, 2023 05:06
@v-klochkov v-klochkov temporarily deployed to aws February 2, 2023 05:33 — with GitHub Actions Inactive
@v-klochkov v-klochkov temporarily deployed to aws February 2, 2023 06:05 — with GitHub Actions Inactive
@v-klochkov v-klochkov requested review from fineg74 and sarnex February 7, 2023 16:57
@v-klochkov v-klochkov merged commit 2517aa1 into intel:sycl Feb 7, 2023
@v-klochkov v-klochkov deleted the esimd_imulh_fix branch February 7, 2023 22:58
v-klochkov added a commit to v-klochkov/llvm-test-suite that referenced this pull request Feb 14, 2023
The test was disabled due to false-alarm. The cases/PRs reporting
this test as 'unrelated fail' used _old_ compiler with _new_ test.

All such PRs had CI runs with the test failed at compilation.

Even though both the PR and LIT tests were merged at same hour,
the compiled used by CI was still old, but the test was new.
PR: intel/llvm#8176
PR-LIT: intel#1566

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov added a commit to intel/llvm-test-suite that referenced this pull request Feb 16, 2023
The test was disabled due to false-alarm. The cases/PRs reporting
this test as 'unrelated fail' used _old_ compiler with _new_ test.

All such PRs had CI runs with the test failed at compilation.

Even though both the PR and LIT tests were merged at same hour,
the compiled used by CI was still old, but the test was new.
PR: intel/llvm#8176
PR-LIT: #1566

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
The test was disabled due to false-alarm. The cases/PRs reporting
this test as 'unrelated fail' used _old_ compiler with _new_ test.

All such PRs had CI runs with the test failed at compilation.

Even though both the PR and LIT tests were merged at same hour,
the compiled used by CI was still old, but the test was new.
PR: intel#8176
PR-LIT: intel/llvm-test-suite#1566

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants