Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Align test parameters with 21.16.19610 driver #266

Merged
merged 8 commits into from
May 7, 2021
Merged

[SYCL] Align test parameters with 21.16.19610 driver #266

merged 8 commits into from
May 7, 2021

Conversation

vladimirlaz
Copy link

No description provided.

@vladimirlaz vladimirlaz requested a review from jbrodman as a code owner May 5, 2021 08:49
@vladimirlaz vladimirlaz mentioned this pull request May 5, 2021
Merged
DenisBakhvalov
DenisBakhvalov reviewed May 5, 2021
View reviewed changes
Copy link

@DenisBakhvalov DenisBakhvalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with IGC_FunctionControl env var. @kychendev, please review.

@kbobrovs
Copy link

kbobrovs commented May 5, 2021

I guess this is a w/a for recently found issue in vector BE.
Setting IGC_FunctionControl to 2 might lead to losing the whole point of the test (3 forced stack call). So I'd rather suggest to mark these as XFAIL.
Adding @kvladimi.

@kychendev
Copy link

Right, changing IGC_FunctionControl from 3 to 2 will use subroutine instead of stack-call, which doesn't seem to serve the purpose of the original tests.

kbobrovs
kbobrovs previously approved these changes May 6, 2021
View reviewed changes
@vladimirlaz vladimirlaz merged commit 5076b10 into intel:intel May 7, 2021
@vladimirlaz vladimirlaz deleted the align_tests_with_driver_update branch May 12, 2021 07:28
vladimirlaz added a commit that referenced this pull request May 12, 2021
@vladimirlaz
Revert "[SYCL] Align test parameters with 21.16.19610 driver (#266)"
a7c72d2 
This reverts commit 5076b10.
@vladimirlaz vladimirlaz mentioned this pull request May 12, 2021
Closed
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
Merge pull request intel#266 from intel-innersource/private/abatashe/…
992df7c 
…remove_program_xmain

[SYCL] Remove usages of program class API (intel#474)
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
@vladimirlaz
Remove program class usages (intel#308)
9a1e75d 
After removal of program class tests were updated in scope of
intel#474. The commit was cherrypicked to xmain
in scope of intel#266. The files removal was missed during cherry pick.
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@vladimirlaz
[SYCL] Align test parameters with 21.16.19610 driver (intel/llvm-test…
3dffd78 
…-suite#266)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DenisBakhvalov DenisBakhvalov DenisBakhvalov left review comments

@kbobrovs kbobrovs kbobrovs approved these changes

@jbrodman jbrodman Awaiting requested review from jbrodman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladimirlaz @kbobrovs @kychendev @DenisBakhvalov