This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Remove program class #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
requested review from
AlexeySachkov,
Fznamznon,
kbobrovs,
Pennycook and
a team
as code owners
added 2 commits
September 27, 2021 15:23
|
intel/llvm#4667 removes the need for |
|
@AlexeySachkov @Fznamznon @kbobrovs @Pennycook friendly ping |
kbobrovs
reviewed
Sep 30, 2021
| @@ -1,6 +1,7 @@ | |||
| // No JITing for host devices and diffrent environment variables on linux and | |||
| // windows. | |||
| // REQUIRES: (level_zero || opencl) && linux | |||
| // XFAIL: * | |||
There was a problem hiding this comment.
here and in other places - would be good to add a comment why XFAIL and what needs to happen to re-enable it
Pennycook
approved these changes
Oct 4, 2021
Fznamznon
approved these changes
Oct 5, 2021
AlexeySachkov
approved these changes
Oct 5, 2021
romanovvlad
approved these changes
Oct 6, 2021
|
intel/llvm#4724 should make the cache work for these tests and should eliminate the need for the |
kbobrovs
approved these changes
Oct 7, 2021
npmiller
added a commit
to npmiller/llvm-test-suite
that referenced
this pull request
Nov 10, 2021
The get_backend test was missing the HIP plugin case. The ESIMD tests are not supported for HIP in general, not just on Nvidia. The subgroup built-ins were added for AMD in intel/llvm#4208. The kernel_info.cpp test was fixed in intel#474 and now passes with HIP. The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia, not on AMD.
vladimirlaz
pushed a commit
that referenced
this pull request
Nov 11, 2021
The get_backend test was missing the HIP plugin case. The ESIMD tests are not supported for HIP in general, not just on Nvidia. The subgroup built-ins were added for AMD in intel/llvm#4208. The kernel_info.cpp test was fixed in #474 and now passes with HIP. The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia, not on AMD.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
…remove_program_xmain [SYCL] Remove usages of program class API (intel#474)
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.