[SYCL] Use device code cache when building kernel bundles #4724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The persistent device code cache, when enabled, is not used when building the underlying native program in a kernel bundle. These changes unify cache lookup with a fallback to program creation from ProgramManager::getBuiltPIProgram with the program creation in ProgramManager::build, ensuring that the latter also uses cached device code. Likewise, ProgramManager::build will write the device code to the persistent cache if it was not there already. Signed-off-by: Steffen Larsen <[email protected]>
|
This eliminates the |
vladimirlaz
approved these changes
Oct 8, 2021
|
@alexbatashev could you wait until the will be nightly with the change is available and submit intel/llvm-test-suite#474 without XFAILs which are expected to be fixed. |
Discussed offline. We will not wait and instead update XFAILs in a follow up PR. |
|
@romanovvlad, @vladimirlaz, there is nothing blocking this PR. Right? |
some E2E tests will XPASS as intel/llvm-test-suite#474 has been submitted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The persistent device code cache, when enabled, is not used when building the underlying native program in a kernel bundle. These changes unify cache lookup with a fallback to program creation from
ProgramManager::getBuiltPIProgramwith the program creation inProgramManager::build, ensuring that the latter also uses cached device code. Likewise,ProgramManager::buildwill write the device code to the persistent cache if it was not there already.