[SYCL] Add LIT tests for handler::host_task() (#3837) #299
Conversation
|
Some tests check both handler::host_task() and handler::codeplay_host_task() to provide reasonable amount of testing for the deprecated codeplay_host_task() method. For example, the test 'SYCL/HostInteropTask/host-task-dependency3.cpp' runs about 37 secs on CPU and my initial move was to add checks for both methods there, which resulted into about 75 secs run on CPU, which seems not reasonable. Thus I simply replaced calls of codeplay_host_task() with host_task() there. |
The method handler::codeplay_host_task() is marked as deprecated. The corresponding changes in LIT tests: intel/llvm-test-suite#299 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
public_vklochkov_host_task
branch
2 times, most recently
from
75f550d to
b2df990
Compare
SYCL/Basic/host-task-dependency.cpp
Outdated
| @@ -146,7 +155,7 @@ void test() { | |||
| Context Ctx{{false}, Queue, {10}, {10}, {10}, {}, {}}; | |||
|
|
|||
| // 0. setup: thread 1 T1: exec smth; thread 2 T2: waits; init flag F = false | |||
| auto A1 = std::async(std::launch::async, Thread1Fn, &Ctx); | |||
| auto A1 = std::async(std::launch::async, Thread1Fn<true>, &Ctx); | |||
There was a problem hiding this comment.
Is it intended to be hardcoded and the next line is unspecified?
There was a problem hiding this comment.
Fixed in abca7580e61609a7ad2bdaeee9c00c9b7c9b885b. Thank you!
v-klochkov
force-pushed
the
public_vklochkov_host_task
branch
2 times, most recently
from
87e9d5f to
abca758
Compare
This patch tests intel/llvm#3837 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
public_vklochkov_host_task
branch
from
abca758 to
939dc29
Compare
* [SYCL] Add LIT tests for handler::host_task() (#3837) This patch tests intel/llvm#3837 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
…3837) (intel/llvm-test-suite#299) * [SYCL] Add LIT tests for handler::host_task() (intel/llvm-test-suite#3837) This patch tests intel#3837 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
This patch tests intel/llvm#3837
Signed-off-by: Vyacheslav N Klochkov [email protected]