Skip to content

[SYCL] Add SYCL-2020 method handler::host_task() #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

v-klochkov
Copy link
Contributor

@v-klochkov v-klochkov commented May 27, 2021

The method handler::codeplay_host_task() is marked as deprecated.

The corresponding changes in LIT tests:
intel/llvm-test-suite#299

Signed-off-by: Vyacheslav N Klochkov [email protected]

The method handler::codeplay_host_task() is marked as deprecated.

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
@v-klochkov v-klochkov force-pushed the public_vklochkov_host_task branch from b2a53d7 to 808c191 Compare May 27, 2021 22:06
@v-klochkov v-klochkov requested a review from s-kanaev May 27, 2021 23:11
@v-klochkov v-klochkov marked this pull request as ready for review May 27, 2021 23:11
@v-klochkov v-klochkov requested a review from a team as a code owner May 27, 2021 23:11
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

host_task_impl(Func);
}

/// Enqueues a command to the SYCL runtime to invoke \p Func once.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment describing enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the code-review!
I copied the comment from SYCL-2020 SPEC, which does not give any additional info other than this.

@v-klochkov v-klochkov merged commit 75e5a26 into intel:sycl Jun 1, 2021
@v-klochkov v-klochkov deleted the public_vklochkov_host_task branch June 1, 2021 17:05
v-klochkov added a commit to v-klochkov/llvm-test-suite that referenced this pull request Jun 7, 2021
This patch tests intel/llvm#3837

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov added a commit to intel/llvm-test-suite that referenced this pull request Jun 8, 2021
* [SYCL] Add LIT tests for handler::host_task() (#3837)

This patch tests intel/llvm#3837

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
smaslov-intel pushed a commit to smaslov-intel/llvm-test-suite that referenced this pull request Aug 12, 2021
* [SYCL] Add LIT tests for handler::host_task() (#3837)

This patch tests intel/llvm#3837

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…3837) (intel/llvm-test-suite#299)

* [SYCL] Add LIT tests for handler::host_task() (intel/llvm-test-suite#3837)

This patch tests intel#3837

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants