-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Add SYCL-2020 method handler::host_task() #3837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The method handler::codeplay_host_task() is marked as deprecated. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
b2a53d7
to
808c191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
host_task_impl(Func); | ||
} | ||
|
||
/// Enqueues a command to the SYCL runtime to invoke \p Func once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment describing enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the code-review!
I copied the comment from SYCL-2020 SPEC, which does not give any additional info other than this.
This patch tests intel/llvm#3837 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
* [SYCL] Add LIT tests for handler::host_task() (#3837) This patch tests intel/llvm#3837 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
* [SYCL] Add LIT tests for handler::host_task() (#3837) This patch tests intel/llvm#3837 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
…3837) (intel/llvm-test-suite#299) * [SYCL] Add LIT tests for handler::host_task() (intel/llvm-test-suite#3837) This patch tests intel#3837 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
The method handler::codeplay_host_task() is marked as deprecated.
The corresponding changes in LIT tests:
intel/llvm-test-suite#299
Signed-off-by: Vyacheslav N Klochkov [email protected]