This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Check cache directory settings #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests to check that: - cache is disabled if no environment variables defining cache root directory are set; - cache can be enabled if at least one evironment variable is set.
|
@vladimirlaz, could you clarify why the tests are passing although intel/llvm#4047 has not been merged yet? |
The checks in the tests were not good enough. I have updated them. |
pvchupin
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 16, 2021
Remove storing JIT cache files to current directory when corresponding environment variables are not set. Complementary test change: intel/llvm-test-suite#337
|
The Windows failures are unrelated. |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Add tests to check that: - cache is disabled if no environment variables defining cache root directory are set; - cache can be enabled if at least one evironment variable is set.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check that:
directory are set;