[SYCL] Do not use current directory for JIT cache #4047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove storing JIT cache files to current directory when corresponding environment variables are not set.
bader
requested changes
Jul 2, 2021
bader
previously approved these changes
Jul 2, 2021
|
I missed the comment about llvm-test-suite tests in a separate PR. |
sergey-semenov
previously approved these changes
Jul 2, 2021
Set SYCL_CACHE_DIR to current directory to make sure that cache is enabled in all environments.
sergey-semenov
previously approved these changes
Jul 5, 2021
bader
reviewed
Jul 6, 2021
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
bader
reviewed
Jul 6, 2021
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
bader
reviewed
Jul 7, 2021
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
bader
reviewed
Jul 7, 2021
sycl/unittests/kernel-and-program/PersistentDeviceCodeCache.cpp
Outdated
Show resolved
Hide resolved
sergey-semenov
approved these changes
Jul 7, 2021
|
@pvchupin could you please review/approve? |
pvchupin
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove storing JIT cache files to current directory when corresponding
environment variables are not set.
Complementary test change: intel/llvm-test-suite#337