This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix tests for future namespace #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork update
Fork update
romanovvlad
approved these changes
Oct 15, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Remove #include of "CL/sycl/access/access.hpp" and "CL/sycl/access/access.hpp" for several reasons: 1)The new approach of namespaces (PR intel#4460) relies on the fact that users include high level header(e.g. CL/sycl.hpp or sycl/sycl.hpp) to resolve final namespaces, so including internal headers directly(especially before high level headers) breaks this approach. 2)The spec doesn't specify names of internal headers, so it's illegal and non-portable to include any other header that high level ones.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove #include of "CL/sycl/access/access.hpp" and "CL/sycl/access/access.hpp" for several reasons.
1)The new approach of namespaces (PR #4460) relies on the fact that users include high level header(e.g. CL/sycl.hpp or sycl/sycl.hpp) to resolve final namespaces, so including internal headers directly(especially before high level headers) breaks this approach.
2)The spec doesn't specify names of internal headers, so it's illegal and non-portable to include any other header that high level one.