-
Notifications
You must be signed in to change notification settings - Fork 787
Support for new namespace #4460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/summary:run |
…vlad/llvm into private2/vromanov/Alias2
/summary:run |
/summary:run |
/summary:run |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Remove #include of "CL/sycl/access/access.hpp" and "CL/sycl/access/access.hpp" for several reasons: 1)The new approach of namespaces (PR intel#4460) relies on the fact that users include high level header(e.g. CL/sycl.hpp or sycl/sycl.hpp) to resolve final namespaces, so including internal headers directly(especially before high level headers) breaks this approach. 2)The spec doesn't specify names of internal headers, so it's illegal and non-portable to include any other header that high level ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to remove cl:: namespace from sycl/sycl.hpp header.
Currently sycl/sycl.hpp exposes SYCL API in cl::sycl namespace. It needs to be changed to just sycl:: so the user code which includes this header and accesses something using cl::sycl should produce an error.
The patch moves all SYCL APIs to a new
__sycl_internal
namespace and imports API from it tocl::sycl
ifCL/sycl.hpp
in included or just tosycl
in case ofsycl/sycl.hpp
:FE and llvm passes are updated accordingly to check for new namespace where it's needed.
In order to keep backward compatibility the patch adds aliases for each exported function from
cl::sycl
namespace to__sycl_internal
namespace.The patch is going to be committed in several pieces:
cl::sycl
)cl::sycl
and__sycl_internal
namespaces and start using the macro during integration header/footer instead ofcl::sycl
cl::sycl
with usages of the macrocl::sycl
with__sycl_ns
(which at this stage will be the same)