Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL ] Test for redefining int specialization const to zero #541

Merged
merged 8 commits into from
Nov 18, 2021
Merged

[SYCL ] Test for redefining int specialization const to zero #541

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
235f952
Test for redefining spec const to 0
maximdimakov Oct 30, 2021
9a43c4b
Test int default value
maximdimakov Oct 30, 2021
5ddfd9e
Clang-format fix
maximdimakov Oct 30, 2021
642a4aa
Add new test case
maximdimakov Nov 8, 2021
ac3c5d1
Clang-format fix
maximdimakov Nov 8, 2021
1a64df0
Merge remote-tracking branch 'origin/intel' into spec_consts
maximdimakov Nov 8, 2021
eb07934
Remove XFAIL due to problem resolved
maximdimakov Nov 8, 2021
0e7a2a2
Return XFAIL line
maximdimakov Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions SYCL/SpecConstants/2020/handler-api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "common.hpp"

constexpr sycl::specialization_id<int> int_id;
constexpr sycl::specialization_id<int> int_id2(2);
constexpr sycl::specialization_id<double> double_id(3.14);
constexpr sycl::specialization_id<custom_type> custom_type_id;

Expand Down Expand Up @@ -69,16 +70,19 @@ int main() {

bool test_default_values(sycl::queue q) {
sycl::buffer<int> int_buffer(1);
sycl::buffer<int> int_buffer2(1);
sycl::buffer<double> double_buffer(1);
sycl::buffer<custom_type> custom_type_buffer(1);

q.submit([&](sycl::handler &cgh) {
auto int_acc = int_buffer.get_access<sycl::access::mode::write>(cgh);
auto int_acc2 = int_buffer2.get_access<sycl::access::mode::write>(cgh);
auto double_acc = double_buffer.get_access<sycl::access::mode::write>(cgh);
auto custom_type_acc =
custom_type_buffer.get_access<sycl::access::mode::write>(cgh);
cgh.single_task<TestDefaultValuesKernel>([=](sycl::kernel_handler kh) {
int_acc[0] = kh.get_specialization_constant<int_id>();
int_acc2[0] = kh.get_specialization_constant<int_id2>();
double_acc[0] = kh.get_specialization_constant<double_id>();
custom_type_acc[0] = kh.get_specialization_constant<custom_type_id>();
});
Expand All @@ -90,6 +94,10 @@ bool test_default_values(sycl::queue q) {
"integer specialization constant (defined without default value)"))
return false;

auto int_acc2 = int_buffer2.get_access<sycl::access::mode::read>();
if (!check_value(2, int_acc2[0], "integer specialization constant"))
return false;

auto double_acc = double_buffer.get_access<sycl::access::mode::read>();
if (!check_value(3.14, double_acc[0], "double specialization constant"))
return false;
Expand Down Expand Up @@ -153,25 +161,30 @@ bool test_set_and_get_on_host(sycl::queue q) {

bool test_set_and_get_on_device(sycl::queue q) {
sycl::buffer<int> int_buffer(1);
sycl::buffer<int> int_buffer2(1);
sycl::buffer<double> double_buffer(1);
sycl::buffer<custom_type> custom_type_buffer(1);

int new_int_value = 8;
int new_int_value2 = 0;
double new_double_value = 3.0;
custom_type new_custom_type_value('b', 1.0, 12);

q.submit([&](sycl::handler &cgh) {
auto int_acc = int_buffer.get_access<sycl::access::mode::write>(cgh);
auto int_acc2 = int_buffer2.get_access<sycl::access::mode::write>(cgh);
auto double_acc = double_buffer.get_access<sycl::access::mode::write>(cgh);
auto custom_type_acc =
custom_type_buffer.get_access<sycl::access::mode::write>(cgh);

cgh.set_specialization_constant<int_id>(new_int_value);
cgh.set_specialization_constant<int_id2>(new_int_value2);
cgh.set_specialization_constant<double_id>(new_double_value);
cgh.set_specialization_constant<custom_type_id>(new_custom_type_value);

cgh.single_task<TestSetAndGetOnDevice>([=](sycl::kernel_handler kh) {
int_acc[0] = kh.get_specialization_constant<int_id>();
int_acc2[0] = kh.get_specialization_constant<int_id2>();
double_acc[0] = kh.get_specialization_constant<double_id>();
custom_type_acc[0] = kh.get_specialization_constant<custom_type_id>();
});
Expand All @@ -182,6 +195,11 @@ bool test_set_and_get_on_device(sycl::queue q) {
"integer specialization constant"))
return false;

auto int_acc2 = int_buffer2.get_access<sycl::access::mode::read>();
if (!check_value(new_int_value2, int_acc2[0],
"integer specialization constant"))
return false;

auto double_acc = double_buffer.get_access<sycl::access::mode::read>();
if (!check_value(new_double_value, double_acc[0],
"double specialization constant"))
Expand Down