This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL ] Test for redefining int specialization const to zero #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mdimakov <[email protected]>
|
Jenkins failure fixed here: #542 |
kbobrovs
reviewed
Oct 30, 2021
| @@ -122,7 +122,7 @@ bool test_set_and_get_on_host(sycl::queue q) { | |||
| "custom_type specializaiton constant before setting any value")) | |||
| ++errors; | |||
|
|
|||
| int new_int_value = 8; | |||
| int new_int_value = 0; | |||
There was a problem hiding this comment.
I'd suggest to add new test cases rather than changing existing ones.
AlexeySachkov
previously approved these changes
Nov 8, 2021
AlexeySachkov
approved these changes
Nov 11, 2021
|
@kbobrovs could you, please, review? |
kbobrovs
approved these changes
Nov 17, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…lvm-test-suite#541) Signed-off-by: mdimakov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is for intel/llvm#4845
Signed-off-by: mdimakov [email protected]