[SYCL] Generate property for default specialization constants values #4845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mdimakov <[email protected]>
maximdimakov
requested review from
kbobrovs,
mlychkov and
a team
as code owners
AlexeySachkov
previously approved these changes
Oct 29, 2021
s-kanaev
previously approved these changes
Oct 29, 2021
maximdimakov
dismissed stale reviews from s-kanaev and AlexeySachkov
via
e2504ee
There was a problem hiding this comment.
@maximdimakov, there seems to be a regression of spec_constants_bool ESIMD test, could you please take a look?
| @@ -235,7 +235,7 @@ attributes #3 = { nounwind } | |||
| ; CHECK: !sycl.specialization-constants = !{![[#ID0:]], ![[#ID1:]], ![[#ID2:]], ![[#ID3:]], ![[#ID_COMPOS3:]], ![[#ID4:]], ![[#ID5:]] | |||
| ; | |||
| ; CHECK-DEF: !sycl.specialization-constants-default-values = !{![[#ID4:]], ![[#ID5:]], ![[#ID6:]], ![[#ID7:]], ![[#ID_COMPOS3_DEFAULT:]], ![[#ID8:]], ![[#ID9:]] | |||
| ; CHECK-RT-NOT: !sycl.specialization-constants-default-values | |||
| ; CHECK-RT: !sycl.specialization-constants-default-values | |||
There was a problem hiding this comment.
Ideally, we should be unifying CHECK-DEF and CHECK-RT for that metadata into a common CHECK, i.e. we should check content of the metadata in both modes.
However, this test is quite complicated and messy already, I plan to refactor those LIT tests to make them cleaner and simpler. Therefore, I'm ok to accept this test as-is.
AlexeySachkov
approved these changes
Nov 8, 2021
|
The problem with spec_const_bool.cpp in precommit happened due to XFAIL line in the test. Fix for it is in the : intel/llvm-test-suite#556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate property not only for native mode helps to DPCPP RT get correct default values of specialization constants.
Signed-off-by: mdimakov [email protected]