This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] expand group_broadcast testing for new update #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be passed to group_broadcast. Here we are re-enabling these tests which will pass once the matching update is merged on intel/llvm Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
requested review from
AlexeySachkov and
Pennycook
as code owners
Pennycook
previously approved these changes
Nov 15, 2021
|
/verify with intel/llvm#4910 |
|
@vladimirlaz is /verify a directive to the CI? I ran 4910 against this test PR here (where it passed): http://icl-jenkins.sc.intel.com:8080/job/SYCL_CI/job/intel/job/Lin/job/LLVM_Test_Suite/7729/ |
Signed-off-by: Chris Perkins <[email protected]>
|
I believe this fix is now needed to get the post-commit failures cleared. |
@Pennycook this is newly added feature which allows to run changes in 2 PRs. the results are available in Jenkins/llvm-test-suite job. |
vladimirlaz
approved these changes
Nov 17, 2021
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…-suite#554) Signed-off-by: Chris Perkins <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are spec clarifications that widen the allowable types that can be passed to
group_broadcastHere we are re-enabling these tests which will pass once the matching update (intel/llvm#4910) is merged on intel/llvmThese expanded tests running (and passing) against supporting commit here: http://icl-jenkins.sc.intel.com:8080/job/SYCL_CI/job/intel/job/Lin/job/LLVM_Test_Suite/7729/
Signed-off-by: Chris Perkins [email protected]