Skip to content

[SYCL] group algorithm routines with broadened supported types #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cperkinsintel
Copy link
Contributor

@cperkinsintel cperkinsintel commented Nov 5, 2021

The spec has broadened the types acceptable to group_broadcast, as well as shift_group_left and a few others. This is needed to support complex numbers.

Tests have been expanded here: intel/llvm-test-suite#554

New tests running against this PR here: http://icl-jenkins.sc.intel.com:8080/job/SYCL_CI/job/intel/job/Lin/job/LLVM_Test_Suite/7729/

Signed-off-by: Chris Perkins [email protected]

Signed-off-by: Chris Perkins <[email protected]>
@cperkinsintel cperkinsintel marked this pull request as ready for review November 15, 2021 17:12
@cperkinsintel cperkinsintel requested a review from a team as a code owner November 15, 2021 17:12
@cperkinsintel cperkinsintel changed the title [SYCL] group_broadcast routines updated [SYCL] group algorithm routines with broadened supported types Nov 15, 2021
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants