This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][HIP] Update XFAIL and UNSUPPORTED for some tests #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
requested review from
againull,
AlexeySachkov,
bader,
kbobrovs,
Pennycook,
romanovvlad,
vladimirlaz,
vzakhari and
a team
as code owners
npmiller
reviewed
Dec 17, 2021
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| // The test is failing sporadically on Windows OpenCL RTs | |||
| // Disabling on windows until fixed | |||
| // UNSUPPORTED: windows | |||
| // UNSUPPORTED: hip_amd, windows | |||
There was a problem hiding this comment.
There's a PR to fix these for HIP:
Unfortunately the PR for the tests got merged first and the actual fix stayed in review, just re-requested review for it today.
There was a problem hiding this comment.
I'll revert these changes if your PR gets approval
npmiller
approved these changes
Dec 17, 2021
bader
approved these changes
Dec 17, 2021
bader
reviewed
Dec 17, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See intel/llvm#8812 for more info