[SYCL][HIP] Enable hip_piEnqueueEventsWaitWithBarrier #4975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch enables piEnqueueEventsWaitWithBarrier for the HIP plugin, it brings it to the same level as the CUDA plugin, see intel#3932. This fixes the `llvm-test-suite`, `SYCL/Basic/submit_barrier.cpp`, `SYCL/Basic/enqueue_barrier.cpp` and `SYCL/Basic/barrier_order.cpp` tests for the HIP plugin.
npmiller
added a commit
to npmiller/llvm-test-suite
that referenced
this pull request
Nov 17, 2021
This is fixed by intel/llvm#4975
| command_queue, num_events_in_wait_list, event_wait_list, event); | ||
| } | ||
|
|
||
| pi_result hip_piEnqueueEventsWaitWithBarrier(pi_queue command_queue, |
There was a problem hiding this comment.
Why is it implemented the same as hip_piEnqueueEventsWait?
There was a problem hiding this comment.
This is because at the moment the queue is represented by just a single in order stream, so effectively every command has an implicit barrier and these two functions end up doing the same thing.
This may need to be changed in the future if we improve how the queue and events are implemented, but at the moment it should work fine. This is also the same reason why the CUDA plugin implements these two the same way as well.
There was a problem hiding this comment.
Please add a source code comment about it
There was a problem hiding this comment.
Updated with some comments
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Nov 18, 2021
This is fixed by intel/llvm#4975
smaslov-intel
approved these changes
Jan 3, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables piEnqueueEventsWaitWithBarrier for the HIP plugin, it
brings it to the same level as the CUDA plugin, see #3932.
This fixes the
llvm-test-suite,SYCL/Basic/submit_barrier.cpp,SYCL/Basic/enqueue_barrier.cppandSYCL/Basic/barrier_order.cpptests for the HIP plugin.