Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Release specialization constant buffer #643

Merged
merged 14 commits into from
Dec 27, 2021

Conversation

HabKaffee
Copy link

This PR includes tests for implemented spec const buffer.
Implementation in intel/llvm.
link to PR with implementation: intel/llvm#5167

Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but generally it looks good.

Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bader
Copy link

bader commented Dec 23, 2021

@kbobrovs, ping.

@HabKaffee
Copy link
Author

Nothing new was added by last commit.

@HabKaffee
Copy link
Author

Jenkins/pre-ci-linux failed due to fail in SYCL :: DiscardEvents/invalid_event.cpp. My test does not affect this test at all.

bader pushed a commit to intel/llvm that referenced this pull request Dec 23, 2021
This patch releases spec const buffer implementation.
Tests is placed to llvm-test-suite - intel/llvm-test-suite#643
@HabKaffee HabKaffee changed the title [SYCL] Spec const buffer releasing [SYCL] Release specialization constant buffer Dec 24, 2021
@vladimirlaz vladimirlaz merged commit e052442 into intel:intel Dec 27, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants