Skip to content

[SYCL] Release specialization constant buffer #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 23, 2021
Merged

[SYCL] Release specialization constant buffer #5167

merged 11 commits into from
Dec 23, 2021

Conversation

HabKaffee
Copy link
Contributor

@HabKaffee HabKaffee commented Dec 17, 2021

This patch releases spec const buffer implementation.
Tests is placed to llvm-test-suite.
link to PR in llvm-test-suite: intel/llvm-test-suite#643

@HabKaffee HabKaffee changed the title draft releasing spec const buffer [SYCL] Spec const buffer releasing Dec 17, 2021
@HabKaffee
Copy link
Contributor Author

/summary:run

@HabKaffee
Copy link
Contributor Author

/summary:run

@HabKaffee
Copy link
Contributor Author

SYCL / Default Linux / HIP AMD GPU Test Suite (pull_request) fails because it can't find xptifw_lib ( NameError: name 'xptifw_lib' is not defined https://github.com/intel/llvm/runs/4604953955?check_suite_focus=true#step:5:1503)

@bader
Copy link
Contributor

bader commented Dec 22, 2021

SYCL / Default Linux / HIP AMD GPU Test Suite (pull_request) fails because it can't find xptifw_lib ( NameError: name 'xptifw_lib' is not defined https://github.com/intel/llvm/runs/4604953955?check_suite_focus=true#step:5:1503)

Should be fixed by intel/llvm-test-suite#655. Please, re-run the job.

@HabKaffee
Copy link
Contributor Author

I re-ran jobs.

@HabKaffee
Copy link
Contributor Author

HabKaffee commented Dec 22, 2021

@bader What should I do if SYCL / Default Linux / HIP AMD GPU Test Suite (pull_request) fails because of SYCL :: GroupAlgorithm/SYCL2020/sort.cpp, but my patch is not affect it at all?

@bader
Copy link
Contributor

bader commented Dec 22, 2021

@bader What should I do if SYCL / Default Linux / HIP AMD GPU Test Suite (pull_request) fails because of SYCL :: GroupAlgorithm/SYCL2020/sort.cpp, but my patch is not affect it at all?

It looks like tested compiler doesn't include 9abe201. I assume it's because re-run took the old version of the sycl branch. I suggest merging tip of the sycl branch to your private branch. This should trigger new pre-commit, which will test updated compiler.

@alexbatashev, FYI.

@HabKaffee
Copy link
Contributor Author

@bader What should I do if SYCL / Default Linux / HIP AMD GPU Test Suite (pull_request) fails because of SYCL :: GroupAlgorithm/SYCL2020/sort.cpp, but my patch is not affect it at all?

It looks like tested compiler doesn't include 9abe201. I assume it's because re-run took the old version of the sycl branch. I suggest merging tip of the sycl branch to your private branch. This should trigger new pre-commit, which will test updated compiler.

@alexbatashev, FYI.

Ok, I'll merge 9abe201 and try again

@bader
Copy link
Contributor

bader commented Dec 22, 2021

I suggest you merge HEAD of the sycl branch to test compatibility with other commits.

@HabKaffee
Copy link
Contributor Author

I suggest you merge HEAD of the sycl branch to test compatibility with other commits.

Got it.

@HabKaffee
Copy link
Contributor Author

/summary:run

@bader bader requested a review from steffenlarsen December 22, 2021 12:48
@bader
Copy link
Contributor

bader commented Dec 22, 2021

/verify with intel/llvm-test-suite#643

vladimirlaz
vladimirlaz previously approved these changes Dec 22, 2021
@HabKaffee
Copy link
Contributor Author

HabKaffee commented Dec 23, 2021

Failure in SYCL / Default Linux / OCL x64 Test Suite (pull_request) (logs) is not associated with this PR

@HabKaffee
Copy link
Contributor Author

Failure in SYCL / Default Linux / OCL x64 Test Suite (pull_request) (logs) is not associated with this PR

Update: new logs

@HabKaffee HabKaffee requested a review from bader December 23, 2021 08:45
@bader
Copy link
Contributor

bader commented Dec 23, 2021

/verify with intel/llvm-test-suite#643

I see a lot of failures in the logs. Most of them are already reported and handled, but I see a few new issues:

Linux_LLVM-Test-Suite_CUDA_FAILURE.log

[2021-12-22T16:18:05.327Z] ********************
[2021-12-22T16:18:05.327Z] Unexpectedly Passed Tests (1):
[2021-12-22T16:18:05.327Z] LLVM :: DeviceLib/built-ins/nan.cpp

Windows_LLVM-Test-Suite_FAILURE.log

[2021-12-22T17:35:48.479Z] Failed Tests (5):
[2021-12-22T17:35:48.479Z] LLVM :: DeviceLib/built-ins/vector_relational.cpp
[2021-12-22T17:35:48.480Z] LLVM :: ESIMD/regression/dgetrf.cpp

Please, make sure these fails are reported.

@bader
Copy link
Contributor

bader commented Dec 23, 2021

@vladimirlaz, please, merge when you think it's ready.

@bader bader removed their request for review December 23, 2021 08:58
@alexbatashev
Copy link
Contributor

XPTI test fails, because test fix also pulled in one line, that is only reported by #5172, which is not in this branch.

I'll think of ways of merging tip of SYCL into current branch to workaround this issue.

@bader
Copy link
Contributor

bader commented Dec 23, 2021

I'll think of ways of merging tip of SYCL into current branch to workaround this issue.

For re-runs?

@alexbatashev
Copy link
Contributor

I'll think of ways of merging tip of SYCL into current branch to workaround this issue.

For re-runs?

Exactly

@HabKaffee
Copy link
Contributor Author

HabKaffee commented Dec 23, 2021

@alexbatashev Do I need merge last commits, merged into sycl, and re-run tests?

@HabKaffee
Copy link
Contributor Author

/summary:run

@bader bader changed the title [SYCL] Spec const buffer releasing [SYCL] Release specialization constant buffer Dec 23, 2021
@bader bader merged commit ae711ab into intel:sycl Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants