This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Remove XFAIL for AMD from group collectives related tests #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4c1
requested review from
AlexeySachkov,
Pennycook and
v-klochkov
as code owners
AlexeySachkov
previously approved these changes
Dec 23, 2021
|
/verify with intel/llvm#5202 |
Pennycook
previously approved these changes
Jan 4, 2022
|
@t4c1, please, resolve merge conflicts. |
againull
approved these changes
Jan 13, 2022
|
@t4c1, SYCL/SubGroup/broadcast* tests don't work - https://github.com/intel/llvm/runs/4808006579?check_suite_focus=true |
|
These tests pass for me :/ Given they are failing on CI I can add back the XFAIL. |
|
Please, do. These tests fail in all recent pre-commit checks. |
bader
pushed a commit
that referenced
this pull request
Jan 14, 2022
Broadcast has recently been implemented for HIP backend in intel/llvm#5202 and XFAIL for AMD HIP was removed in #656. However on CI machines these tests are still failing, so we need to mark them XFAIL again
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Broadcast has recently been implemented for HIP backend in intel#5202 and XFAIL for AMD HIP was removed in intel/llvm-test-suite#656. However on CI machines these tests are still failing, so we need to mark them XFAIL again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove XFAIL for AMD from group collectives related tests. Tests changes in: intel/llvm#5202