[SYCL][HIP][libclc] Add group collective functions for HIP #5202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pennycook
approved these changes
Jan 4, 2022
bader
approved these changes
Jan 12, 2022
|
@intel/llvm-reviewers-runtime, ping. |
s-kanaev
approved these changes
Jan 12, 2022
According to the description these changes are covered by intel/llvm-test-suite#656. Are these enough or want to have libclc specific tests? |
|
Sorry, I missed the question. In my opinion the tests in the test suite should suffice. |
|
@againull, intel/llvm-test-suite#656 must be merged at the same time, otherwise, pre-commit checks on AMD GPU will be broken. |
Thank you, merged. |
bader
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jan 14, 2022
Broadcast has recently been implemented for HIP backend in intel/llvm#5202 and XFAIL for AMD HIP was removed in #656. However on CI machines these tests are still failing, so we need to mark them XFAIL again
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Broadcast has recently been implemented for HIP backend in intel#5202 and XFAIL for AMD HIP was removed in intel/llvm-test-suite#656. However on CI machines these tests are still failing, so we need to mark them XFAIL again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds group collective functions (reduce, scans, broadcast) for HIP.
Tested by: intel/llvm-test-suite#656