Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Exclude esimd_vadd_raw_send from DG1 test. #728

Merged

Conversation

kychendev
Copy link

The block read/write function implementation is not compatible on DG1.

@kychendev kychendev requested a review from a team as a code owner January 11, 2022 21:02
@kychendev kychendev requested a review from kbobrovs January 11, 2022 21:02
kbobrovs
kbobrovs previously approved these changes Jan 11, 2022
@@ -7,7 +7,7 @@
//
//===----------------------------------------------------------------------===//
// REQUIRES: gpu
// UNSUPPORTED: cuda || hip
// UNSUPPORTED: gpu-intel-dg1,cuda,hip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok/Good, but please add the TODO comment while it is known.
I.e. would be good to copy the description of this PR to the line above, something like:
"TODO: The block read/write function implementation is not compatible on DG1"

@kychendev
Copy link
Author

@kbobrovs , all checks passed, please merge. Thanks.

@v-klochkov v-klochkov merged commit 3a9a0d3 into intel:intel Jan 12, 2022
@kychendev kychendev deleted the private/kchen-esimd-fix-vadd-raw-send branch January 12, 2022 22:34
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
…esting (intel#728)

Change-Id: I9da43fde08efebabe22263f2d95dfcef0ac2e058
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
[ESIMD] Exclude esimd_vadd_raw_send and histogram_raw_send from DG1 testing (intel#728)
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants