This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Enhance enum logging support #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kochetkov, Yuriy <[email protected]>
It's usefull to have for value packs with enum type Signed-off-by: Kochetkov, Yuriy <[email protected]>
We should avoid function templates specialization in general Signed-off-by: Kochetkov, Yuriy <[email protected]>
By using `log::stringify()` call instead of the hard-coded `std::to_string()` calls we enable the `StringMaker` usage with all benefits of any custom specialization provided. Signed-off-by: Kochetkov, Yuriy <[email protected]>
|
@vasilytric Would you mind to take a look? |
|
@sndmitriev Would you mind to take a look? |
|
@sndmitriev Friendly ping as #921 depends on it |
|
Thanks :) @kbobrovs Would you mind to merge this PR? |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
* [SYCL][ESIMD] Add `value_pack::generate_named_by()` It's usefull to have for value packs with enum type * [SYCL][ESIMD] Add `log::StringMaker<>` for specialization We should avoid function templates specialization in general * [SYCL][ESIMD] Use `StringMaker` in `value_pack` generation By using `log::stringify()` call instead of the hard-coded `std::to_string()` calls we enable the `StringMaker` usage with all benefits of any custom specialization provided. Signed-off-by: Kochetkov, Yuriy <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* [SYCL][ESIMD] Add `value_pack::generate_named_by()` It's usefull to have for value packs with enum type * [SYCL][ESIMD] Add `log::StringMaker<>` for specialization We should avoid function templates specialization in general * [SYCL][ESIMD] Use `StringMaker` in `value_pack` generation By using `log::stringify()` call instead of the hard-coded `std::to_string()` calls we enable the `StringMaker` usage with all benefits of any custom specialization provided. Signed-off-by: Kochetkov, Yuriy <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides two major API enhancements:
value_pack::generate_named_by- to use custom stringification functionslog::StringMakerspecialization supportNote that any
StringMakerspecialization will be automatically used withinvalue_pack::generate_named(void)callAlso fixes compilation with
ESIMD_TESTS_VERBOSE_LOGenabledSigned-off-by: Kochetkov, Yuriy [email protected]