This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add tests on simd load from accessors #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To distinguish from the simd load constructors from accessor Signed-off-by: Kochetkov, Yuriy <[email protected]>
To use generic code for both USM and accessor-based tests Signed-off-by: Kochetkov, Yuriy <[email protected]>
To clarify exact value used for the load constructor tests Signed-off-by: Kochetkov, Yuriy <[email protected]>
Makes possible: - power-of-two smoke tests with overaligned<1> - byte order smoke tests Signed-off-by: Kochetkov, Yuriy <[email protected]>
Signed-off-by: Kochetkov, Yuriy <[email protected]>
Signed-off-by: Kochetkov, Yuriy <[email protected]>
Based on idea that offset should be a multiplier of alignment for simd load constructor to work as expected Signed-off-by: Kochetkov, Yuriy <[email protected]>
|
Rebased over the latest @vasilytric Would you mind to take a look? I've tried to split changes in |
vasilytric
reviewed
Mar 21, 2022
Signed-off-by: Kochetkov, Yuriy <[email protected]>
|
@sndmitriev Would you mind to take a look? |
yuriykoch
commented
Mar 24, 2022
|
As there is a restriction on possible |
Signed-off-by: Kochetkov, Yuriy <[email protected]>
vasilytric
reviewed
Mar 31, 2022
vasilytric
reviewed
Mar 31, 2022
vasilytric
reviewed
Mar 31, 2022
vasilytric
reviewed
Mar 31, 2022
Co-authored-by: vasilytric <[email protected]>
|
@kbobrovs Would you mind to take a look? |
kbobrovs
approved these changes
Apr 1, 2022
| const auto single_type = | ||
| named_type_pack<signed char>::generate("signed char"); | ||
|
|
||
| passed &= for_all_combinations<ctors::run_test>( |
There was a problem hiding this comment.
This is really cool - the robustness of the infra to create new test combinations!
|
@vladimirlaz, the failure is unrelated - this is a clang++ crash on test compilation. Recently internal tickets were submitted on similar cases - e.g. by @dongkyunahn-intel. Please merge. Failed Tests (1): |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
Based on idea that offset should be a multiplier of alignment flag, and alignment flag should be less strict than simd element alignment itself for simd load constructor to work as expected. Signed-off-by: Kochetkov, Yuriy [email protected]
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
Auto pulldown and update tc files for xmain branch on 20220512
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…suite#921) Based on idea that offset should be a multiplier of alignment flag, and alignment flag should be less strict than simd element alignment itself for simd load constructor to work as expected. Signed-off-by: Kochetkov, Yuriy [email protected]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on idea that offset should be a multiplier of alignment flag, and
alignment flag should be less strict than simd element alignment itself
for simd load constructor to work as expected.
Signed-off-by: Kochetkov, Yuriy [email protected]