Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] [L0] [PI] Corrections to interop tests to ensure batching behavior #948

Closed
wants to merge 5 commits into from
Closed

[SYCL] [L0] [PI] Corrections to interop tests to ensure batching behavior #948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d83c251
[SYCL] [L0] [PI] Corrections to tests to ensure desired batching beha…
rdeodhar Mar 23, 2022
3698e83
Additional tests that need explicit batching.
rdeodhar Mar 24, 2022
cd383b0
Merge branch 'intel' of https://github.com/intel/llvm-test-suite into…
rdeodhar Mar 24, 2022
b4c52e5
Added test for usage of immediate commandlists.
rdeodhar Mar 25, 2022
bd2b681
Formatting change.
rdeodhar Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SYCL/Plugin/interop-level-zero-interop-task-mem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// REQUIRES: level_zero, level_zero_dev_kit
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %level_zero_options %s -o %t.out
// RUN: env SYCL_BE=PI_LEVEL_ZERO %GPU_RUN_PLACEHOLDER %t.out
// RUN: env SYCL_BE=PI_LEVEL_ZERO SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=2 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %GPU_RUN_PLACEHOLDER %t.out
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any check of traces in this test, so it should run with any env settings


// Test for Level Zero interop_task.

Expand Down
2 changes: 1 addition & 1 deletion SYCL/Plugin/interop-level-zero-keep-ownership.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// REQUIRES: level_zero, level_zero_dev_kit
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out %level_zero_options
// RUN: env SYCL_BE=PI_LEVEL_ZERO %GPU_RUN_PLACEHOLDER %t.out
// RUN: env SYCL_BE=PI_LEVEL_ZERO SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=2 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %GPU_RUN_PLACEHOLDER %t.out
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any check of traces in this test, so it should run with any env settings


// Test for Level Zero interop API where SYCL RT doesn't take ownership

Expand Down
2 changes: 1 addition & 1 deletion SYCL/Plugin/interop-level-zero-thread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// REQUIRES: level_zero, level_zero_dev_kit
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out %level_zero_options %threads_lib
// RUN: %BE_RUN_PLACEHOLDER %t.out
// RUN: env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=2 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %BE_RUN_PLACEHOLDER %t.out
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

//
// CHECK: Running iteration 0
// CHECK: Running iteration 1
Expand Down
3 changes: 3 additions & 0 deletions SYCL/Plugin/level_zero_dynamic_batch_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

// Check that dynamic batching raises/lowers batch size
// RUN: env SYCL_PI_TRACE=2 ZE_DEBUG=1 SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=2 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %GPU_RUN_PLACEHOLDER %t.out 2>&1 | FileCheck --check-prefixes=CKALL,CKDYN %s
// Check that with immediate commandlists, only 2 are created and destroyed
// RUN: env ZE_DEBUG=4 SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=1 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %GPU_RUN_PLACEHOLDER %t.out 2>&1 | FileCheck --check-prefixes=CKIMM %s

// level_zero_dynamic_batch_test.cpp
//
Expand Down Expand Up @@ -34,6 +36,7 @@
// CKALL: Test Pass
// CKALL: Test Pass
// CKALL: Test Pass
// CKIMM: zeCommandListCreate = 0 \---> zeCommandListDestroy = 2

#include "CL/sycl.hpp"
#include <chrono>
Expand Down