This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] [L0] [PI] Corrections to interop tests to ensure batching behavior #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vior independent of defaults. Signed-off-by: Rajiv Deodhar <[email protected]>
|
/verify with #948 |
|
/verify with intel/llvm#5833 |
| @@ -1,6 +1,6 @@ | |||
| // REQUIRES: level_zero, level_zero_dev_kit | |||
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %level_zero_options %s -o %t.out | |||
| // RUN: env SYCL_BE=PI_LEVEL_ZERO %GPU_RUN_PLACEHOLDER %t.out | |||
| // RUN: env SYCL_BE=PI_LEVEL_ZERO SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=2 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %GPU_RUN_PLACEHOLDER %t.out | |||
There was a problem hiding this comment.
I don't see any check of traces in this test, so it should run with any env settings
| @@ -1,6 +1,6 @@ | |||
| // REQUIRES: level_zero, level_zero_dev_kit | |||
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out %level_zero_options | |||
| // RUN: env SYCL_BE=PI_LEVEL_ZERO %GPU_RUN_PLACEHOLDER %t.out | |||
| // RUN: env SYCL_BE=PI_LEVEL_ZERO SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=2 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %GPU_RUN_PLACEHOLDER %t.out | |||
There was a problem hiding this comment.
I don't see any check of traces in this test, so it should run with any env settings
smaslov-intel
suggested changes
Mar 25, 2022
| @@ -1,6 +1,6 @@ | |||
| // REQUIRES: level_zero, level_zero_dev_kit | |||
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out %level_zero_options %threads_lib | |||
| // RUN: %BE_RUN_PLACEHOLDER %t.out | |||
| // RUN: env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=2 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %BE_RUN_PLACEHOLDER %t.out | |||
|
These tests fail if immediate commandlists are used in the L0 plugin. |
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
CMPLRTST-15892: support translate gpu-intel-* to alloy gpu feature.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some interop tests depend on assumptions about the plugin behavior with regard to commandlist and event usage. The expectations can be met by setting env vars that control batching and device-only events usage.